Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create View As" functionality is broken after SQLLAB_BACKEND_PERSISTENCE is set to True #21665

Closed
3 tasks done
zhaorui2022 opened this issue Sep 30, 2022 · 3 comments
Closed
3 tasks done
Labels
#bug Bug report v2.0

Comments

@zhaorui2022
Copy link
Contributor

After we upgrade superset to 2.0.0, we got user reports saying "Create View As" is broken and it shows an error message saying "No stored results found, you need to re-run your query", and if rerunning, it will complain the view already exists. After disabling SQLLAB_BACKEND_PERSISTENCE, it solves the issue. But SQLLAB_BACKEND_PERSISTENCE is set to True by default in 2.0.0.

How to reproduce the bug

  1. Go to SQL Lab's SQL editor
  2. Select a database where it allows "Create View As"
  3. Write any query
  4. Click on "Create View As" button in the dropdown list next to "Run" button. And fill in the information as expected.
  5. See the error on the UI.

Expected results

The UI should show it has successfully created the view with a link to explore the view immediately.

Actual results

Shows an error.

Screenshots

Screen Shot 2022-09-30 at 11 13 55 AM

Environment

(please complete the following information):

  • browser type and version: N/A, not browser specific
  • superset version: 2.0.0
  • python version: 3.8
  • node.js version: not specific to node.js version
  • any feature flags active: has the error when SQLLAB_BACKEND_PERSISTENCE is set to true

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@zhaorui2022 zhaorui2022 added the #bug Bug report label Sep 30, 2022
@zhaorui2022
Copy link
Contributor Author

If anyone else also experience this issue, can we set this feature flag to False by default in upcoming patch releases? We had the feature flag enabled for 2 days, and after disabling it, users were reporting their previous query tabs were reset to the default one (no query history, and all queries become "SELECT * FROM WHERE")

@mayurnewase
Copy link
Contributor

couldn't reproduce on latest master (last sha: 8f74e46d45ca94f5656f7b881f1096c16657c829)

@eschutho
Copy link
Member

I tested this in 2.0.1 and it seems to work, too. I'll close this ticket since it was verified as fixed on master as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report v2.0
Projects
None yet
Development

No branches or pull requests

3 participants