Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the CROSS_REFERENCE feature flag #21708

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds the CROSS_REFERENCE feature flag
  • Sorts the features flags alphabetically in the files
  • Adds the PLEASE KEEP THE LIST SORTED ALPHABETICALLY comments for developers

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #21708 (96da926) into master (7b66e0b) will not change coverage.
The diff coverage is n/a.

❗ Current head 96da926 differs from pull request most recent head d37eff2. Consider uploading reports for the commit d37eff2 to get more accurate results

@@           Coverage Diff           @@
##           master   #21708   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1799     1799           
  Lines       68875    68875           
  Branches     7319     7319           
=======================================
  Hits        46044    46044           
  Misses      20944    20944           
  Partials     1887     1887           
Flag Coverage Δ
javascript 53.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
superset/config.py 91.61% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 1cbf066 into apache:master Oct 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants