feat: Add dataset visuals for when a table is selected #21893
Conversation
| {tableName} | ||
| <RefreshLabel | ||
| onClick={() => { | ||
| console.log( |
There was a problem hiding this comment.
is this console log necessary?
There was a problem hiding this comment.
It's not, it was more a flag/placeholder for when the functionality is added into the next ticket.
| @@ -65,6 +65,9 @@ export function datasetReducer( | |||
| } | |||
| } | |||
|
|
|||
| const prevUrl = | |||
There was a problem hiding this comment.
I'm not sure the status of this URL, I just moved it out so it didn't get lost in the middle of the other components.
Codecov Report
@@ Coverage Diff @@
## master #21893 +/- ##
===========================================
+ Coverage 55.55% 66.91% +11.36%
===========================================
Files 1806 1807 +1
Lines 69140 69359 +219
Branches 7393 7474 +81
===========================================
+ Hits 38409 46415 +8006
+ Misses 28822 21014 -7808
- Partials 1909 1930 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| import { EmptyStateBig } from 'src/components/EmptyState'; | ||
|
|
||
| type DatasetPanelProps = { | ||
| tableName?: string | null | undefined; |
There was a problem hiding this comment.
Do we need the null | undefined taking into account that the field is optional? Cannot just be :
tableName?: string ?
There was a problem hiding this comment.
Oh yeah good call! Corrected in this commit.
There was a problem hiding this comment.
Actually, this prop is null when a table isn't selected so I added it to the type in this commit. Undefined wasn't needed here though, so still a good call, thanks! 😁
mistercrunch
added
🏷️ bot
SUMMARY
This PR implements the visuals in the dataset panel that appear when a table is selected.
ANIMATED GIF
TESTING INSTRUCTIONS
http://localhost:9000/dataset/add/?testingADDITIONAL INFORMATION