Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): Move dashboard auto refresh intervals options to config #21924

Merged
merged 9 commits into from
Oct 27, 2022

Conversation

zhaorui2022
Copy link
Contributor

SUMMARY

The original dashboard auto-fresh intervals were hard-coded. However, based on the back-end query engine architecture, some options might not work. Move these options to config file so that they can be customized.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

With default option, there is no change on the UI. Tested with customized options in config file.

Google.Chrome.-.COVID.Vaccine.Dashboard.-.2022-10-24.at.2.44.22.PM.mp4

Also verified the auto refresh function is still working as expected.

TESTING INSTRUCTIONS

If testing with original options, no change is needed. Otherwise, change the options in the config file. Run docker-compose up and then view auto refresh options in any dashboard.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #21924 (d85c162) into master (f41d0b0) will decrease coverage by 11.40%.
The diff coverage is 61.22%.

❗ Current head d85c162 differs from pull request most recent head 5eda9c5. Consider uploading reports for the commit 5eda9c5 to get more accurate results

@@             Coverage Diff             @@
##           master   #21924       +/-   ##
===========================================
- Coverage   66.82%   55.42%   -11.41%     
===========================================
  Files        1805     1807        +2     
  Lines       69070    69197      +127     
  Branches     7373     7402       +29     
===========================================
- Hits        46159    38354     -7805     
- Misses      21005    28932     +7927     
- Partials     1906     1911        +5     
Flag Coverage Δ
mysql ?
postgres ?
presto 52.83% <64.10%> (+<0.01%) ⬆️
python 57.61% <71.79%> (-23.66%) ⬇️
sqlite ?
unit 51.08% <58.97%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...i-chart-controls/src/sections/forecastInterval.tsx 100.00% <ø> (ø)
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...s/superset-ui-core/src/components/SafeMarkdown.tsx 66.66% <ø> (ø)
...d/packages/superset-ui-core/src/query/constants.ts 100.00% <ø> (ø)
...uperset-ui-core/src/query/types/AnnotationLayer.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...d/packages/superset-ui-core/src/utils/isDefined.ts 100.00% <ø> (ø)
... and 432 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bkyryliuk bkyryliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work and looks like it is aligned with a general frontend config approach e.g. https://github.com/apache/superset/search?q=DASHBOARD_AUTO_REFRESH_MODE

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 24, 2022
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 25, 2022
zhaorui2022 and others added 3 commits October 26, 2022 09:56
…l.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…l.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…l.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://54.244.1.135:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements and for addressing the comments @zhaorui2022

@michael-s-molina michael-s-molina merged commit edce579 into apache:master Oct 27, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants