fix: BIGINT rendering regression in chartAction #21937
Conversation
| }; | ||
|
|
||
| return SupersetClient.post(querySettings); | ||
| return SupersetClient.post(querySettings).then(({ text, response }) => ({ |
There was a problem hiding this comment.
@justinpark can we add a simply unit test which includes an integer with a value greater than 2^53 -1?
|
How about we change the default |
@ktmud good idea. I originally thought same way. let me add new parseMethod type |
justinpark
force-pushed
the
fix--big-number-in-chart-data
branch
from
187cfde
to
8dbea45
Compare
| 'json-bigint', | ||
| ); | ||
| expect(`${responseBigNumber.json.value}`).toEqual('9223372036854775807'); | ||
| }); |
There was a problem hiding this comment.
Do we also mock a -2^63 to test int64? and we also need to add a comment to point out the integer type is that singed int64.
There was a problem hiding this comment.
@zhaoyongjie good point. I added the spec for negative number.
Codecov Report
@@ Coverage Diff @@
## master #21937 +/- ##
==========================================
+ Coverage 66.90% 66.92% +0.01%
==========================================
Files 1807 1807
Lines 69183 69182 -1
Branches 7405 7403 -2
==========================================
+ Hits 46288 46298 +10
+ Misses 20985 20973 -12
- Partials 1910 1911 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| 'json-bigint', | ||
| ); | ||
| expect(`${responseBigNumber.json.value}`).toEqual('9223372036854775807'); | ||
| }); |
There was a problem hiding this comment.
Do we also mock a -2^63 to test int64? and we also need to add a comment to point out the integer type is that singed int64.
(cherry picked from commit 4002406)
(cherry picked from commit 4002406)
mistercrunch
added
🏷️ bot
SUMMARY
Since chart data api
/api/v1/chart/dataresponds the bigint in number format, the number beyond the JS limit that are replaced with the special number.This commit introduces new parseMethod
json-bigintto fix the unmatched value displaying for these big numbers.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
SELECT 568485382077428896 as BIGNUMADDITIONAL INFORMATION
cc: @john-bodley @ktmud