Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): panels are collapsed when switch native filters #21976

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

In native filter, every time we switch the filter, we will reset the activeKey of the collapsing panel (control behavior), which will lead to some unnecessary rendering, but in fact we just need to set the default value and let the component control itself (uncontrol behavior)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2022-10-17.at.6.34.33.PM.mov

after

2022-10-31.2.32.10.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #21976 (3542669) into master (bf00193) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21976   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files        1807     1807           
  Lines       69231    69231           
  Branches     7406     7406           
=======================================
  Hits        46357    46357           
  Misses      20966    20966           
  Partials     1908     1908           
Flag Coverage Δ
javascript 53.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 59.50% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

@michael-s-molina Ephemeral environment spinning up at http://52.27.156.97:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenLYZ stephenLYZ merged commit 9b6322b into apache:master Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants