Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply border radius and fix height for MetadataBar #22010

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Nov 2, 2022

SUMMARY

Apply minor CSS changes to make MetadataBar consistent with designs.

  1. Add border-radius: 4px
  2. MetadataBar had height 34.5px instead of 32px. Adding line-height: 1 to the container and line-height: 0 to the icons fixed it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@kasiazjc
Copy link
Contributor

kasiazjc commented Nov 2, 2022

Awesome, thank you!

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #22010 (e75b5fd) into master (435926b) will increase coverage by 11.57%.
The diff coverage is n/a.

❗ Current head e75b5fd differs from pull request most recent head 9eb40f2. Consider uploading reports for the commit 9eb40f2 to get more accurate results

@@             Coverage Diff             @@
##           master   #22010       +/-   ##
===========================================
+ Coverage   55.46%   67.03%   +11.57%     
===========================================
  Files        1841     1812       -29     
  Lines       70220    69373      -847     
  Branches     7670     7448      -222     
===========================================
+ Hits        38947    46504     +7557     
+ Misses      29291    20949     -8342     
+ Partials     1982     1920       -62     
Flag Coverage Δ
javascript 53.50% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/MetadataBar/MetadataBar.tsx 98.21% <ø> (ø)
...t-frontend/src/dashboard/actions/dashboardState.js 37.09% <0.00%> (-15.85%) ⬇️
...et-frontend/src/dashboard/actions/dashboardInfo.ts 50.00% <0.00%> (-13.27%) ⬇️
superset/views/annotations.py 81.96% <0.00%> (-6.93%) ⬇️
...hboard/components/nativeFilters/FilterBar/utils.ts 53.84% <0.00%> (-6.16%) ⬇️
superset/db_engine_specs/databricks.py 77.27% <0.00%> (-5.66%) ⬇️
...t-frontend/src/dashboard/reducers/dashboardInfo.js 75.00% <0.00%> (-5.00%) ⬇️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 31.25% <0.00%> (-4.47%) ⬇️
...iews/CRUD/data/dataset/AddDataset/Footer/index.tsx 33.33% <0.00%> (-4.17%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 91.30% <0.00%> (-3.94%) ⬇️
... and 454 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 389e44e into apache:master Nov 29, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants