Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add metadata namespace #22020

Merged

Conversation

waynewenswag
Copy link
Contributor

SUMMARY

Add metadata.namespace to deploy with kustomize

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls bump chart version

@waynewenswag
Copy link
Contributor Author

Added and thanks!

@craig-rueda
Copy link
Member

@Yann-J - any idea why CI is failing here?

@Yann-J
Copy link
Contributor

Yann-J commented Nov 9, 2022

Yeah, the new helm-docs pre-commit hook failed, because the version was bumped but the README was not updated to reflect that.

@waynewenswag I cannot push to your branch to fix it, but all you need is to run all pre-commit checks with pre-commit run --all.

You may need to install/update them or their dependencies first of course:

# install helm-docs
brew install norwoodj/tap/helm-docs
# install all hooks
pre-commit install-hooks

@waynewenswag
Copy link
Contributor Author

waynewenswag commented Nov 9, 2022

@Yann-J @craig-rueda Fixed

@craig-rueda
Copy link
Member

Awesome, thanks @Yann-J !

@craig-rueda craig-rueda merged commit 53ed8f2 into apache:master Nov 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants