Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept only JSON credentials #22040

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

In the file dialog for selecting credentials for BigQuery, allow only JSON files to be selected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2022-11-04 at 11 23 00 AM

After is the same, but only JSON files can be selected. :)

TESTING INSTRUCTIONS

  1. Add Biguery DB, click file upload button.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #22040 (45f51bb) into master (9832bbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22040   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        1815     1815           
  Lines       69540    69540           
  Branches     7483     7483           
=======================================
  Hits        46592    46592           
  Misses      21017    21017           
  Partials     1931     1931           
Flag Coverage Δ
javascript 53.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...aseModal/DatabaseConnectionForm/EncryptedField.tsx 10.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down locally to test it out, it works! LGTM 😁

Screenshot 2022-11-07 at 2 28 09 PM

@betodealmeida betodealmeida merged commit cd1b379 into apache:master Nov 7, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants