fix(alerts): execute query as report executor #22167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22167 +/- ##
=======================================
Coverage 66.99% 66.99%
=======================================
Files 1833 1833
Lines 69936 69938 +2
Branches 7572 7572
=======================================
+ Hits 46855 46857 +2
Misses 21121 21121
Partials 1960 1960
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dpgaspar
approved these changes
Nov 18, 2022
| owner_names: List[str], | ||
| creator_name: Optional[str], | ||
| config: List[ReportScheduleExecutor], | ||
| executor: Union[str, Exception], |
There was a problem hiding this comment.
nit: it may be easier to read if you rename this to expected_result makes more sense when condensing usernames and exceptions
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a continuation of #21931 which made it possible to execute reports as the object owners/creators etc. Unfortunately that PR didn't enable the same functionality for alerts, which were still being executed as the selenium user. This implements the same logic for alerts and adds integration tests to ensure alerts are executed as the correct user.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION