Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: root context provider extension point #22188

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Adds an extension point in the root context chain to provide a hook at the app level.
This enables custom library installation/configuration that needs to be done at the app level

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@diegomedina248 diegomedina248 force-pushed the dm/feat/root-context-provider-extension-point branch from 6d01930 to 4945ef6 Compare November 22, 2022 01:14
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #22188 (4945ef6) into master (ac0ff78) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #22188      +/-   ##
==========================================
- Coverage   67.00%   66.99%   -0.01%     
==========================================
  Files        1835     1835              
  Lines       69971    69974       +3     
  Branches     7590     7591       +1     
==========================================
  Hits        46881    46881              
- Misses      21124    21127       +3     
  Partials     1966     1966              
Flag Coverage Δ
javascript 53.80% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...perset-frontend/src/views/RootContextProviders.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jfrag1 jfrag1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilykuang lilykuang merged commit aa97ba4 into apache:master Dec 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants