fix: (dashboard) Adds optional chaining to avoid runtime error #22213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator on null or undefined value
Codecov Report
@@ Coverage Diff @@
## master #22213 +/- ##
=======================================
Coverage 66.92% 66.92%
=======================================
Files 1835 1835
Lines 69988 69988
Branches 7612 7612
=======================================
Hits 46839 46839
Misses 21183 21183
Partials 1966 1966
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
🏷️ preset:2022.47 |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds optional chaining to avoid runtime error when performing dot operator on null or undefined value. In the case a bad componentId was provided to these utility functions the code would throw a runtime error in loop causing the removal of a component or dashboard tab to fail.
If there is a dashboard filter (even if not applied) deleting a tab will hit the line that causes error with a bad componentId. If there is a dashboard filter AND it is applied, then removing a component will hit the line that causes error with a bad componentId.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION