Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file_upload): Fix columnar and Excel upload forms #22249

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

One of the form fields we changed when working on CSV forms was the not very descriptive "con" field, which was renamed to "database". Now, we are updating Columnar and Excel forms so they both stop displaying an error message. Additionally, we updated our tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
test1

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Change forms fileds names for columnar and excel form views so they both use the same database DOM element as CSV form.
- Update our tests and the places where columnar and excel upload where using the not very descriptive "con" field
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #22249 (37a05f6) into master (435926b) will increase coverage by 10.01%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           master   #22249       +/-   ##
===========================================
+ Coverage   55.46%   65.48%   +10.01%     
===========================================
  Files        1841     1841               
  Lines       70220    70220               
  Branches     7670     7670               
===========================================
+ Hits        38947    45981     +7034     
+ Misses      29291    22257     -7034     
  Partials     1982     1982               
Flag Coverage Δ
hive 52.56% <50.00%> (?)
mysql 78.07% <50.00%> (?)
postgres 78.14% <50.00%> (?)
presto ?
python 78.48% <50.00%> (+21.03%) ⬆️
sqlite 76.59% <50.00%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/database/views.py 31.36% <0.00%> (+0.90%) ⬆️
superset/views/database/forms.py 85.71% <100.00%> (ø)
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) ⬇️
superset/utils/pandas_postprocessing/select.py 38.46% <0.00%> (-61.54%) ⬇️
... and 320 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrey-zayats
Copy link

QA tested. Fix LGTM!

@hughhhh hughhhh merged commit fb3e717 into apache:master Nov 29, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.47

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants