Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Programmatically open "more filters" dropdown in Horizontal Filter Bar #22276

Merged
merged 14 commits into from
Dec 2, 2022

Conversation

geido
Copy link
Member

@geido geido commented Nov 30, 2022

SUMMARY

This PR adds the ability to open the "more filters" dropdown in the horizontal filter bar while refactoring the code to better differentiate between focus and hover actions on native filters.

AFTER

FCC.New.Coder.Survey.2018.mp4

TESTING INSTRUCTIONS

  1. Enable HORIZONTAL_FILTER_BAR feature flag
  2. Open a dashboard
  3. Set the filter bar to horizontal
  4. Click on a filter that is currently within the "more filters" dropdown
  5. The dropdown should open and focus the filter

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #22276 (0be3929) into master (2bdf22b) will increase coverage by 11.22%.
The diff coverage is 43.47%.

@@             Coverage Diff             @@
##           master   #22276       +/-   ##
===========================================
+ Coverage   55.69%   66.92%   +11.22%     
===========================================
  Files        1846     1847        +1     
  Lines       70302    70602      +300     
  Branches     7689     7819      +130     
===========================================
+ Hits        39157    47247     +8090     
+ Misses      29151    21343     -7808     
- Partials     1994     2012       +18     
Flag Coverage Δ
hive 52.55% <ø> (ø)
javascript 53.92% <39.13%> (+0.13%) ⬆️
mysql 78.04% <ø> (?)
postgres 78.11% <ø> (?)
presto 52.45% <ø> (ø)
python 81.30% <ø> (+23.51%) ⬆️
sqlite 76.57% <ø> (?)
unit 50.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...nd/src/dashboard/components/FiltersBadge/index.tsx 86.11% <0.00%> (ø)
...Filters/FilterBar/FilterControls/FilterControl.tsx 29.03% <ø> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx 5.71% <0.00%> (-0.61%) ⬇️
.../components/nativeFilters/FilterBar/Horizontal.tsx 100.00% <ø> (ø)
...rd/components/nativeFilters/FilterBar/Vertical.tsx 74.50% <ø> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 50.00% <ø> (ø)
...ativeFilters/FilterBar/useFilterControlFactory.tsx 81.81% <ø> (ø)
...t-frontend/src/dashboard/reducers/nativeFilters.ts 40.74% <0.00%> (-3.26%) ⬇️
...filters/components/GroupBy/GroupByFilterPlugin.tsx 0.00% <ø> (ø)
... and 325 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geido and others added 8 commits December 1, 2022 12:44
….jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…yles.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…yles.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
…yles.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
@kgabryje
Copy link
Member

kgabryje commented Dec 1, 2022

/testenv up FEATURE_HORIZONTAL_FILTER_BAR=true

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

@kgabryje Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

@geido geido closed this Dec 1, 2022
@geido geido reopened this Dec 1, 2022
@michael-s-molina
Copy link
Member

michael-s-molina commented Dec 1, 2022

@geido Can you rebase this? Docker fix is here

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed 1 regression. In filter cards we have "Dependent on" section, with links to filters that given filter is dependent on. Previously clicking on that link would highlight the parent filter and currently nothing happens
image

@geido
Copy link
Member Author

geido commented Dec 1, 2022

Thanks for catching that @kgabryje! I am having a look

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@geido geido merged commit df91664 into master Dec 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the feat/hfb-open-more-filters branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants