fix: Horizontal filter bar resizing #22286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #22286 +/- ##
==========================================
+ Coverage 66.79% 66.89% +0.09%
==========================================
Files 1846 1846
Lines 70286 70286
Branches 7683 7683
==========================================
+ Hits 46948 47017 +69
+ Misses 21346 21277 -69
Partials 1992 1992
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgabryje
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
Lgtm! However what's worrying me is that the filters are reloading when they are popping back into view. We're using reverse portals to avoid it and that solution worked in vertical filter bar when changing filter's state in/out of scope - the filters don't reload there if they were already loaded. Seems like that solution doesn't work here
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes horizontal filter bar resizing by making the central container use the available space. This also aligns the Apply and Clear All buttons to the right in a similar way they are aligned to the bottom when in vertical mode.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-11-30.at.3.37.18.PM.mov
TESTING INSTRUCTIONS
Check the video for instructions.
ADDITIONAL INFORMATION