fix: add columns back into SQL Lab to Explore Flow #22320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
from
9456586
to
d89ffdf
Compare
Codecov Report
@@ Coverage Diff @@
## master #22320 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 1847 1847
Lines 70482 70482
Branches 7721 7721
=======================================
Hits 47120 47120
Misses 21362 21362
Partials 2000 2000
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://54.191.121.186:8080. Credentials are |
eschutho
approved these changes
Dec 2, 2022
|
@eschutho of course! |
AAfghahi
force-pushed
the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
from
d89ffdf
to
2aebb07
Compare
AAfghahi
force-pushed
the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
from
2aebb07
to
cab248b
Compare
AAfghahi
force-pushed
the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
4 times, most recently
from
fcde51b
to
6c7a30e
Compare
AAfghahi
force-pushed
the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
from
6c7a30e
to
a1153a6
Compare
hughhhh
approved these changes
Dec 5, 2022
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
mistercrunch
deleted the
arash.afghahi/sc-62358/chart-in-explore-columns-are-missing-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Columns were lost when SQL lab was refactored in the last month, it is now its own separate prop, and we need to rebuild the query object when it is updated. This PR adds columns back to the query model so that when we open the save dataset modal that it is present.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-12-02.at.2.55.57.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION