Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Fix autocomplete for SQL Lab #22329

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

Autocompleter uses the table name in the reducer, but info is not being updated so it fails to provide autocomplete options. when opening new tabs. With these changes we make sure such info is available so options can be properly displayed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test

TESTING INSTRUCTIONS

  1. Open SQL Lab and verify the autocomplete for columns work as expected on new tabs

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Fix autocomplete on new tabs
- Fix test so it considers new store updates from our changes
@lyndsiWilliams
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

@lyndsiWilliams Ephemeral environment spinning up at http://54.203.5.239:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #22329 (c172469) into master (aafb993) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c172469 differs from pull request most recent head b0de559. Consider uploading reports for the commit b0de559 to get more accurate results

@@           Coverage Diff           @@
##           master   #22329   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files        1846     1846           
  Lines       70513    70515    +2     
  Branches     7726     7727    +1     
=======================================
+ Hits        47132    47134    +2     
  Misses      21378    21378           
  Partials     2003     2003           
Flag Coverage Δ
javascript 53.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/TableSelector/index.tsx 78.20% <100.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AAfghahi AAfghahi merged commit 96de314 into apache:master Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants