Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart-list): Hide 'Dashboards added to' column. #22475

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Dec 20, 2022

SUMMARY

Hides the "Dashboards added to" column in the chart CRUD view, as infinite re-renders in its use of useTruncation are causing full-page crashes in some reported cases. This is a temporary fix until a permanent fix can be found.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-12-20 at 6 44 17 PM

After:
Screen Shot 2022-12-20 at 6 44 35 PM

TESTING INSTRUCTIONS

  • Confirm that page still loads as expected
  • Confirm that it's still possible to filter by dashboards added to

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codyml codyml force-pushed the fix/disable-dashboards-column branch from 5f8a6fc to b692f17 Compare December 20, 2022 19:18
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #22475 (e3df667) into master (21b56b2) will decrease coverage by 0.00%.
The diff coverage is 80.55%.

❗ Current head e3df667 differs from pull request most recent head 2dba173. Consider uploading reports for the commit 2dba173 to get more accurate results

@@            Coverage Diff             @@
##           master   #22475      +/-   ##
==========================================
- Coverage   66.91%   66.91%   -0.01%     
==========================================
  Files        1850     1850              
  Lines       70695    70705      +10     
  Branches     7750     7756       +6     
==========================================
+ Hits        47309    47312       +3     
- Misses      21370    21374       +4     
- Partials     2016     2019       +3     
Flag Coverage Δ
javascript 53.85% <80.55%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/legacy-preset-chart-nvd3/src/DistBar/index.js 66.66% <ø> (ø)
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 52.11% <ø> (+0.05%) ⬆️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 54.26% <ø> (-0.78%) ⬇️
...iews/CRUD/data/dataset/AddDataset/Header/index.tsx 57.14% <33.33%> (-24.68%) ⬇️
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 84.61% <50.00%> (-2.71%) ⬇️
...erset-frontend/src/components/EmptyState/index.tsx 77.55% <75.00%> (-0.23%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 53.05% <100.00%> (+0.26%) ⬆️
...a/dataset/AddDataset/DatasetPanel/DatasetPanel.tsx 90.19% <100.00%> (+2.96%) ⬆️
...set-frontend/src/views/CRUD/data/dataset/styles.ts 100.00% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codyml codyml force-pushed the fix/disable-dashboards-column branch from f182b5b to 78f951d Compare December 20, 2022 20:06
@codyml codyml force-pushed the fix/disable-dashboards-column branch from 78f951d to 2dba173 Compare December 20, 2022 20:09
@eschutho eschutho merged commit 7a94f3a into apache:master Dec 20, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.49

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Dec 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants