Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): disable flaky tests #22512

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 22, 2022

SUMMARY

The recent PR #22302 broke a few tests that were assuming certain examples were created by the admin user. For some reason CI didn't catch this, and gave the PR a green checkmark. Since this is an incorrect assumption (they should not be created/owned by anyone), we need to refactor the tests so that they aren't testing incorrect behavior. Alternatively, we may change how examples are created and assigned owners. In addition, the tests should be made less flaky to ensure they fail correctly.

This is just a hotfix to unblock master branch, but I will follow up with a proper fix later.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

it('should filter by created by correctly', () => {
xit('should filter by owners by correctly', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bycatch: copypasta

@villebro villebro mentioned this pull request Dec 22, 2022
9 tasks
@villebro
Copy link
Member Author

Ping @codyml and @EugeneTorap .

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those specs pass locally for me now, thanks!

@villebro
Copy link
Member Author

Those specs pass locally for me now, thanks!

Thanks @codyml!

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #22512 (92f8658) into master (7d8fff8) will not change coverage.
The diff coverage is n/a.

❗ Current head 92f8658 differs from pull request most recent head 1d4dc8e. Consider uploading reports for the commit 1d4dc8e to get more accurate results

@@           Coverage Diff           @@
##           master   #22512   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files        1851     1851           
  Lines       70696    70696           
  Branches     7764     7764           
=======================================
  Hits        47299    47299           
  Misses      21375    21375           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 630c129 into apache:master Dec 22, 2022
@villebro villebro deleted the villebro/hotfix-cypress branch December 22, 2022 19:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants