fix(cypress): disable flaky tests #22512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
requested review from
jinghua-qa,
geido,
eschutho,
rusackas and
betodealmeida
as code owners
villebro
commented
Dec 22, 2022
| it('should filter by created by correctly', () => { | ||
| xit('should filter by owners by correctly', () => { |
|
Ping @codyml and @EugeneTorap . |
villebro
force-pushed
the
villebro/hotfix-cypress
branch
from
1fd84be
to
7797b0d
Compare
codyml
approved these changes
Dec 22, 2022
Thanks @codyml! |
villebro
force-pushed
the
villebro/hotfix-cypress
branch
from
5331fbd
to
1d4dc8e
Compare
rusackas
approved these changes
Dec 22, 2022
Codecov Report
@@ Coverage Diff @@
## master #22512 +/- ##
=======================================
Coverage 66.90% 66.90%
=======================================
Files 1851 1851
Lines 70696 70696
Branches 7764 7764
=======================================
Hits 47299 47299
Misses 21375 21375
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Jan 3, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The recent PR #22302 broke a few tests that were assuming certain examples were created by the admin user. For some reason CI didn't catch this, and gave the PR a green checkmark. Since this is an incorrect assumption (they should not be created/owned by anyone), we need to refactor the tests so that they aren't testing incorrect behavior. Alternatively, we may change how examples are created and assigned owners. In addition, the tests should be made less flaky to ensure they fail correctly.
This is just a hotfix to unblock master branch, but I will follow up with a proper fix later.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION