feat(helm): add deploymentLabels variable #22541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuherbert
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
craig-rueda
reviewed
Dec 29, 2022
| # -- Annotations to be added to supersetNode deployment | ||
| deploymentAnnotations: {} | ||
| # -- Labels to be added to supersetNode deployment | ||
| deploymentLabels: {} |
There was a problem hiding this comment.
Pls update the schema to reflect this addition
There was a problem hiding this comment.
Hi, fixed thanks !
villebro
changed the title
|
Still looking like there's failed checks |
|
Pls rebase after this merges: #22590 (should fix linting errors) |
added 2 commits
January 5, 2023 11:27
Signed-off-by: Mathieu Herbert <math.herbert@gmail.com>
Signed-off-by: Mathieu Herbert math.herbert@gmail.com
mathieuherbert
force-pushed
the
helm-resources
branch
from
fe07674
to
1fc7857
Compare
|
Hey, rebased is done |
craig-rueda
approved these changes
Jan 5, 2023
|
Pls make sure you run helm-docs to generate the readme. Looks like that check is still failing |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mathieu Herbert math.herbert@gmail.com
add deploymentLabels as we have for annotations.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION