Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dockerfile): fix "unhealthy" container state #22663

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

artemonsh
Copy link
Contributor

@artemonsh artemonsh commented Jan 10, 2023

SUMMARY

curl should be installed in dockerfile for healthcheck to run successfully.

BEFORE

By running docker inspect one could get these logs:

"Id": "bc38b7d06cd8dbd77e6f21e3b1f37ef4a92decb8a1011c7e87b72bfa2bd33142",
"Created": "2023-01-10T08:58:57.630882874Z",
"Path": "/bin/sh",
"Args": [
    "-c",
    "/app/docker/docker-ci.sh"
],
"State": {
    "Status": "running",
    "Running": true,
    "Paused": false,
    "Restarting": false,
    "OOMKilled": false,
    "Dead": false,
    "Pid": 266447,
    "ExitCode": 0,
    "Error": "",
    "StartedAt": "2023-01-10T08:58:58.043622806Z",
    "FinishedAt": "0001-01-01T00:00:00Z",
    "Health": {
        "Status": "unhealthy",
        "FailingStreak": 380,
        "Log": [
            {
                "Start": "2023-01-10T15:07:33.895631604+03:00",
                "End": "2023-01-10T15:07:33.993237455+03:00",
                "ExitCode": 127,
                "Output": "/bin/sh: 1: curl: not found\n"
            },

BEFORE/AFTER: image

TESTING INSTRUCTIONS

Run docker build, run container and check its status.

ADDITIONAL INFORMATION

  • Has associated issue: fixes unhealthy "app" and "worker" docker containers #12895
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! I assume this is a regression from #21326 , and there may be others, too, as the image slimmed down quite a bit.

@villebro villebro merged commit 1e3746b into apache:master Jan 10, 2023
@artemonsh artemonsh deleted the fix-docker-unhealthy branch January 14, 2023 10:57
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unhealthy "app" and "worker" docker containers
3 participants