Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add schema_name column to Database model #247

Closed
wants to merge 2 commits into from
Closed

add schema_name column to Database model #247

wants to merge 2 commits into from

Conversation

ariepratama
Copy link

referring to this issue: #217
I think this will solve problems for connecting to different schema, tested on local postgres but not yet on redshift

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.03% when pulling e2cc28e on ariepratama:issue_217 into c3789d5 on airbnb:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.03% when pulling e2cc28e on ariepratama:issue_217 into c3789d5 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 71.209% when pulling e2cc28e on ariepratama:issue_217 into c3789d5 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 71.209% when pulling e2cc28e on ariepratama:issue_217 into c3789d5 on airbnb:master.

@ariepratama ariepratama closed this Apr 4, 2016
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@kristw
feat(encodable): implement axis functions for ChannelEncoder (apache#247
2cf401b 
)

* feat: add axis encoder

* test: add unit test

* fix: params

* refactor: rename

* fix: address comments

* fix: update import

* fix: error

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat(encodable): implement axis functions for ChannelEncoder (apache#247
0348641 
)

* feat: add axis encoder

* test: add unit test

* fix: params

* refactor: rename

* fix: address comments

* fix: update import

* fix: error

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@nytai @zhaoyongjie
fix: pass all props to transformProps in LineMulti chart (apache#247)
d173f58
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat(encodable): implement axis functions for ChannelEncoder (apache#247
6da646f 
)

* feat: add axis encoder

* test: add unit test

* fix: params

* refactor: rename

* fix: address comments

* fix: update import

* fix: error

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@nytai @zhaoyongjie
fix: pass all props to transformProps in LineMulti chart (apache#247)
08463cd
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat(encodable): implement axis functions for ChannelEncoder (apache#247
2a8fd2b 
)

* feat: add axis encoder

* test: add unit test

* fix: params

* refactor: rename

* fix: address comments

* fix: update import

* fix: error

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@nytai @zhaoyongjie
fix: pass all props to transformProps in LineMulti chart (apache#247)
2f6f0e8
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat(encodable): implement axis functions for ChannelEncoder (apache#247
9ef8318 
)

* feat: add axis encoder

* test: add unit test

* fix: params

* refactor: rename

* fix: address comments

* fix: update import

* fix: error

* fix: lint
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@nytai @zhaoyongjie
fix: pass all props to transformProps in LineMulti chart (apache#247)
ade25f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ariepratama @landscape-bot @coveralls