Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A better welcome page #250

Merged
merged 1 commit into from
Apr 4, 2016
Merged

A better welcome page #250

merged 1 commit into from
Apr 4, 2016

Conversation

mistercrunch
Copy link
Member

  • now using panels
  • added search on each panel
  • using pagination
  • loading spinner
    screen shot 2016-04-03 at 10 03 12 pm

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 872001c on airbnb:better_welcome into ca44432 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.16% when pulling 872001c2bb711f37bda51419e0703249c35da184 on better_welcome into ca44432 on master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling b2efdf5 on airbnb:better_welcome into ca44432 on airbnb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 71.172% when pulling b2efdf5 on better_welcome into ca44432 on master.

williaster
williaster reviewed Apr 4, 2016
View reviewed changes
caravel/assets/javascripts/welcome.js
@@ -4,12 +4,13 @@ var jQuery = window.jQuery = $;
require('../stylesheets/caravel.css');
require('../stylesheets/welcome.css');
require('bootstrap');
require('datatables');
require('datatables.net-bs');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man sorry if I broke this with the npm package change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it wasn't broken on my side, I was getting deprecation warnings...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, if you don't have a fresh build, it could have been using old node_modules, npm prune cleans up to whatever is defined in the package.json

@williaster
Copy link
Contributor

nice! LGTM 👍

@mistercrunch mistercrunch merged commit f1830c3 into master Apr 4, 2016
@mistercrunch mistercrunch deleted the better_welcome branch April 4, 2016 23:12
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@kristw
feat(encodable): only set scale domain if both bounds are defined (ap…
2ea1764 
…ache#250)

* feat: only set scale domain if both bounds are presented

* fix: unit test

* fix: more optimize
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat(encodable): only set scale domain if both bounds are defined (ap…
c7b3ae1 
…ache#250)

* feat: only set scale domain if both bounds are presented

* fix: unit test

* fix: more optimize
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @data-ui/histogram from 0.0.81 to 0.0.82 (apache#250)
a57c095 
Bumps [@data-ui/histogram](https://github.com/williaster/data-ui) from 0.0.81 to 0.0.82.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.81...v0.0.82)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat(encodable): only set scale domain if both bounds are defined (ap…
d3acc1c 
…ache#250)

* feat: only set scale domain if both bounds are presented

* fix: unit test

* fix: more optimize
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @data-ui/histogram from 0.0.81 to 0.0.82 (apache#250)
6ceb8eb 
Bumps [@data-ui/histogram](https://github.com/williaster/data-ui) from 0.0.81 to 0.0.82.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.81...v0.0.82)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat(encodable): only set scale domain if both bounds are defined (ap…
d09ce88 
…ache#250)

* feat: only set scale domain if both bounds are presented

* fix: unit test

* fix: more optimize
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @data-ui/histogram from 0.0.81 to 0.0.82 (apache#250)
ba7a064 
Bumps [@data-ui/histogram](https://github.com/williaster/data-ui) from 0.0.81 to 0.0.82.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.81...v0.0.82)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat(encodable): only set scale domain if both bounds are defined (ap…
b672373 
…ache#250)

* feat: only set scale domain if both bounds are presented

* fix: unit test

* fix: more optimize
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@dependabot-preview @zhaoyongjie
build(deps): bump @data-ui/histogram from 0.0.81 to 0.0.82 (apache#250)
381a16e 
Bumps [@data-ui/histogram](https://github.com/williaster/data-ui) from 0.0.81 to 0.0.82.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](williaster/data-ui@v0.0.81...v0.0.82)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This was referenced Jan 12, 2022
Closed
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mistercrunch @landscape-bot @coveralls @williaster