Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated queries contain LIMIT even though allow_limit_clause = False in dbEngineSpec. #26068

Closed
3 tasks done
Afsalmc opened this issue Nov 22, 2023 · 1 comment · Fixed by #27215
Closed
3 tasks done
Assignees

Comments

@Afsalmc
Copy link

Afsalmc commented Nov 22, 2023

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Go to 'Sqllab'
  2. Click on 'SEE TABLE SCHEMA'
  3. Scroll down to any schema and click it to preview the table schema.
  4. Click the Copy select statement button near table name.
  5. In select query you can see LIMIT keyword.

Expected results

Generate query with TOP or anything other than LIMIT since allow_limit_clause is false.

Actual results

Query with LIMIT keyword.

Screenshots

image

Environment

(please complete the following information):

  • browser type and version:
  • superset version: 3.0.1
  • python version: 3.10
  • node.js version: v18.12.1

Checklist

Make sure to follow these steps before submitting your issue - thank you!`

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@Afsalmc
Copy link
Author

Afsalmc commented Nov 25, 2023

@michael-s-molina @betodealmeida May I know in the code where it is adding limit 100 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants