refactor: Removes the deprecated REMOVE_SLICE_LEVEL_LABEL_COLORS feature flag #26346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
risk:breaking-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26346 +/- ##
==========================================
+ Coverage 69.06% 69.09% +0.02%
==========================================
Files 1930 1934 +4
Lines 75309 75364 +55
Branches 8429 8417 -12
==========================================
+ Hits 52013 52073 +60
+ Misses 21149 21126 -23
- Partials 2147 2165 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
changed the title
geido
approved these changes
Jan 5, 2024
eschutho
approved these changes
Jan 8, 2024
Muhammed-baban
pushed a commit
to intellica-tech/reporting-tool
that referenced
this pull request
Jan 19, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR removes the
REMOVE_SLICE_LEVEL_LABEL_COLORSfeature flag. The feature flag was used to remove color-related attributes from a chart's form data to reduce payload when the chart was loaded as part of the dashboard initialization. These attributes are not loaded anymore making this optimization obsolete.The previous value of the feature flag was
Falseand now the feature is permanently removed.TESTING INSTRUCTIONS
CI should be sufficient for merging this PR. We'll do a complete testing of 4.0 after all approved proposals are merged.
ADDITIONAL INFORMATIO