Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Holder Full Screen is not working #27561

Closed
2 of 3 tasks
sebint opened this issue Mar 19, 2024 · 6 comments
Closed
2 of 3 tasks

Chart Holder Full Screen is not working #27561

sebint opened this issue Mar 19, 2024 · 6 comments
Assignees

Comments

@sebint
Copy link

sebint commented Mar 19, 2024

Bug description

Unable to enter into Fullscreen state in chart container due to

const DragDroppableStyles = styled.div`
  ${({ theme }) => css`
    position: relative;
    /*
      Next line is a workaround for a bug in react-dnd where the drag
      preview expands outside of the bounds of the drag source card, see:
      https://github.com/react-dnd/react-dnd/issues/832#issuecomment-442071628
    */
    transform: translate3d(0, 0, 0);

When I remove transform: translate3d(0, 0, 0); Its working.

Since its a fix for react-dnd, I would like to know if there are other solutions.

How to reproduce the bug

  1. Go to any dashboard.
  2. Go to any chart slice in the dashboard
  3. Click on the slice control
  4. Click on dropdown item "Enter fullscreen"

Screenshots/recordings

screenshot-localhost_8088-2024 03 19-14_22_42
Default View

screenshot-localhost_8088-2024 03 19-14_22_13
Clicked on "Enter Fullscreen"

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@maybeyourking
Copy link

I also had the same problem.

@rusackas
Copy link
Member

This probably isn't related necessarily, but could be a "two birds, one stone" situation:
#24752

@sadpandajoe
Copy link
Contributor

Heads up this isn't happening with 4.0rc1 from what I can tell from the ephemeral in the PR. So It's probably one of the commits that's happening afterwards.

@sadpandajoe
Copy link
Contributor

relates to this PR: #27308 if it is transform: translate3d(0, 0, 0);

@rusackas
Copy link
Member

@justinpark do you recall the specifics of that line? I'm guessing it's the GPU hack for the browser, but maybe not. If you know a reliable way to test the original bug you were chasing, I can throw some other CSS approaches at it and hopefully open a PR to fix this.

@michael-s-molina
Copy link
Member

Fixed by #27613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants