-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Unable to edit mail list of existing alert & reports #28709
Comments
Hello, @pankajsoni22! 👋 I'm here to help you with any bugs, questions, or contributions you have regarding the repository. To resolve the issue in Superset version 4.0.1-dev where you are unable to edit the mail list of existing alerts and reports because the mail list edit area becomes read-only after saving, you need to ensure that the Here is the relevant part of the code that handles the update of notification settings: const updateNotificationSetting = (
index: number,
setting: NotificationSetting,
) => {
const settings: NotificationSetting[] = [...notificationSettings];
settings[index] = setting;
// if you've changed notification method -> remove trailing methods
if (notificationSettings[index].method !== setting.method) {
notificationSettings[index] = setting;
setNotificationSettings(
notificationSettings.filter((_, idx) => idx <= index),
);
if (notificationSettings.length - 1 > index) {
setNotificationAddState('active');
}
if (setting.method !== undefined && notificationAddState !== 'hidden') {
setNotificationAddState('active');
}
} else {
setNotificationSettings(settings);
}
}; This function updates the notification settings when a change is made. Ensure that this function is correctly called when the notification settings are updated in the Additionally, ensure that the <NotificationMethod
setting={notificationSetting}
index={i}
key={`NotificationMethod-${i}`}
onUpdate={updateNotificationSetting}
onRemove={removeNotificationSetting}
onInputChange={onInputChange}
email_subject={currentAlert?.email_subject || ''}
defaultSubject={emailSubject || ''}
setErrorSubject={handleErrorUpdate}
/> If the issue persists, verify that the state updates are correctly propagated and that there are no other parts of the code that might be causing the mail list edit area to become read-only [1].
|
@pankajsoni22 could share the configs you used for the email alerts I am not able to setup mine I keep getting |
I too am having this same issue, where the "Add" button in the report edit dialog box is not activated even when I have satisfied all the requirements to create an alert. |
Bug description
When we create alert or report and want to sent to receivers using their mail id, it is working fine, we can create alerts and report successfully.
BUT
If we want to add more recipients and try to edit and add more mail to alerts or reports it is not possible. looks like after saving alert/report the mail list edit area becomes read-only.
How to reproduce the bug
Screenshots/recordings
No response
Superset version
4.0.1
Python version
I don't know
Node version
I don't know
Browser
Chrome
Additional context
I'm using superset 4.0.1-dev version
Checklist
The text was updated successfully, but these errors were encountered: