Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50 - Deprecate the KV_STORE feature flag #29162

Closed
justinpark opened this issue Jun 10, 2024 · 3 comments
Closed

50 - Deprecate the KV_STORE feature flag #29162

justinpark opened this issue Jun 10, 2024 · 3 comments
Assignees
Labels
change:backend Requires changing the backend

Comments

@justinpark
Copy link
Member

This proposal is to deprecate the KV_STORE feature flag and its related assets such as the API endpoint and keyvalue table. The main dependency of this feature is the SHARE_QUERIES_VIA_KV_STORE feature flag which allows sharing SQL Lab queries without the necessity of saving the query. Our intention is to use the permalink feature to implement this use case before 5.0 and that's why we are deprecating the feature flag now.

#26450

@rusackas
Copy link
Member

Is this supposed to be on the 5.0 board?

@michael-s-molina
Copy link
Member

michael-s-molina commented Jun 11, 2024

This was completed in 4.0. Closing.

@michael-s-molina
Copy link
Member

michael-s-molina commented Jun 11, 2024

This card was only about deprecating the feature flag. The task to actually remove the KV Store is here. @justinpark if you want to reference a 5.0 issue, you can just use its link. You don't need to convert the task to an issue. I updated you PR to reference the correct card 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:backend Requires changing the backend
Projects
No open projects
Status: Completed
Development

No branches or pull requests

3 participants