Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] onChange is triggered too quick #3868

Closed
3 tasks done
graceguo-supercat opened this issue Nov 15, 2017 · 3 comments · Fixed by #4003
Closed
3 tasks done

[DatePicker] onChange is triggered too quick #3868

graceguo-supercat opened this issue Nov 15, 2017 · 3 comments · Fixed by #4003
Labels
good first issue Good first issues for new contributors

Comments

@graceguo-supercat
Copy link

graceguo-supercat commented Nov 15, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

dgracknjej

Superset version

0.21dev

Actual results

When user changes input in Date picker, onChange event is triggered right away. In dashboard, this will cause new query send out for each slice.

Expected results

Can we trigger onChange only after user clicks "OK"?

@mistercrunch

@mistercrunch
Copy link
Member

Yes we should wait for Ok to call onchange

@betodealmeida
Copy link
Member

@mistercrunch, can you assign this to me? I have a working fix.

@mistercrunch
Copy link
Member

It appears it's not possible to assign to people who don't have write access.

@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good first issues for new contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants