-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[para] don't limit parallel coordinates table size #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before we limited the table size to 10 rows, now there's no limit and it will overflow properly with a scrollbar.
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* chore(release): publish v0.13.7 * Revert "chore(release): publish v0.13.7" This reverts commit 3c9ce9ed4c46f9a52fd78bd9b43732803e93c0ac. * Revert "chore(release): publish v0.13.6" This reverts commit 0e6e829beba0df62a717601b20fdd790ebf49714. * feat: poc using style package in big-number * ThemeProvider decorator * removing other themeProvider stuff (no longer needed) * just adding a note to the readme that this stuff works out of the box. * bumps n deps * BigNumber using theme bits... in theory * wordCloud using theme bits * bumping packages again * fixing dependencies * moving style package to peer deps to fix some SUPER annoying errors * nixing css style, to let Emotion do the talking * moving wordCloud to style pkg to peerDeps. * Nixing CSS file, putting all the styles in one place at export * condensing imports * nixing extraneous package * getting emotion stuff out of word cloud for now (that's another PR!) Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* chore(release): publish v0.13.7 * Revert "chore(release): publish v0.13.7" This reverts commit 3c9ce9ed4c46f9a52fd78bd9b43732803e93c0ac. * Revert "chore(release): publish v0.13.6" This reverts commit 0e6e829beba0df62a717601b20fdd790ebf49714. * feat: poc using style package in big-number * ThemeProvider decorator * removing other themeProvider stuff (no longer needed) * just adding a note to the readme that this stuff works out of the box. * bumps n deps * BigNumber using theme bits... in theory * wordCloud using theme bits * bumping packages again * fixing dependencies * moving style package to peer deps to fix some SUPER annoying errors * nixing css style, to let Emotion do the talking * moving wordCloud to style pkg to peerDeps. * Nixing CSS file, putting all the styles in one place at export * condensing imports * nixing extraneous package * getting emotion stuff out of word cloud for now (that's another PR!) Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* chore(release): publish v0.13.7 * Revert "chore(release): publish v0.13.7" This reverts commit 3c9ce9ed4c46f9a52fd78bd9b43732803e93c0ac. * Revert "chore(release): publish v0.13.6" This reverts commit 0e6e829beba0df62a717601b20fdd790ebf49714. * feat: poc using style package in big-number * ThemeProvider decorator * removing other themeProvider stuff (no longer needed) * just adding a note to the readme that this stuff works out of the box. * bumps n deps * BigNumber using theme bits... in theory * wordCloud using theme bits * bumping packages again * fixing dependencies * moving style package to peer deps to fix some SUPER annoying errors * nixing css style, to let Emotion do the talking * moving wordCloud to style pkg to peerDeps. * Nixing CSS file, putting all the styles in one place at export * condensing imports * nixing extraneous package * getting emotion stuff out of word cloud for now (that's another PR!) Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* chore(release): publish v0.13.7 * Revert "chore(release): publish v0.13.7" This reverts commit 3c9ce9ed4c46f9a52fd78bd9b43732803e93c0ac. * Revert "chore(release): publish v0.13.6" This reverts commit 0e6e829beba0df62a717601b20fdd790ebf49714. * feat: poc using style package in big-number * ThemeProvider decorator * removing other themeProvider stuff (no longer needed) * just adding a note to the readme that this stuff works out of the box. * bumps n deps * BigNumber using theme bits... in theory * wordCloud using theme bits * bumping packages again * fixing dependencies * moving style package to peer deps to fix some SUPER annoying errors * nixing css style, to let Emotion do the talking * moving wordCloud to style pkg to peerDeps. * Nixing CSS file, putting all the styles in one place at export * condensing imports * nixing extraneous package * getting emotion stuff out of word cloud for now (that's another PR!) Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
This was referenced Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we limited the table size to 10 rows, now there's no limit and it
will overflow properly with a scrollbar.