Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Lab - A multi-tab SQL editor #514

Merged
merged 19 commits into from
Aug 30, 2016
Merged

SQL Lab - A multi-tab SQL editor #514

merged 19 commits into from
Aug 30, 2016

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented May 25, 2016 •
edited

screen shot 2016-08-06 at 11 23 41 pm

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling dc0c143 on airbnb:carapal into 7d27692 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 13, 2016 •
edited

Coverage Status

Coverage increased (+0.7%) to 81.876% when pulling 7abd6f8 on carapal into 09c95fb on master.

@mistercrunch mistercrunch force-pushed the carapal branch 2 times, most recently from ee317ec to a90482e Compare July 21, 2016 05:26
@coveralls
Copy link

coveralls commented Jul 21, 2016 •
edited

Coverage Status

Coverage decreased (-0.7%) to 80.5% when pulling a90482e on carapal into fa0497d on master.

@coveralls
Copy link

coveralls commented Jul 21, 2016 •
edited

Coverage Status

Coverage decreased (-0.6%) to 80.548% when pulling 7c16689 on carapal into fa0497d on master.

@mistercrunch mistercrunch mentioned this pull request Jul 21, 2016
Closed
14 tasks
@naveenh1
Copy link

In which release we will have this feature.

@mistercrunch
Copy link
Member Author

@naveenh1 we should have a working version of this within a few weeks

@mistercrunch mistercrunch force-pushed the carapal branch 5 times, most recently from 29d2272 to d0d28e3 Compare August 6, 2016 01:15
@mistercrunch mistercrunch changed the title Carapal react mockup SQL Lab - A multi-tab SQL editor Aug 7, 2016
@mistercrunch mistercrunch added the airbnb Airbnb related label Aug 7, 2016
@mistercrunch
Copy link
Member Author

@ascott I think this is ready for a first round of review

@coveralls
Copy link

coveralls commented Aug 8, 2016 •
edited

Coverage Status

Coverage decreased (-0.7%) to 80.812% when pulling 1a43349 on carapal into 7c810db on master.

@mistercrunch
Copy link
Member Author

@bkyryliuk the commit log you brought in looks pretty bad, rebase over merge! Ideally there should only have been your commits stacked on top of mine.

@bkyryliuk
Copy link
Member

my fault.
@mistercrunch - any idea how can I fix that?

@ascott
Copy link
Contributor

ascott commented Aug 11, 2016

sorry @mistercrunch haven't had a chance to look at this yet, will take a look tonight.

ascott
ascott reviewed Aug 11, 2016
View reviewed changes
caravel/assets/javascripts/SqlLab/components/QueryLog.jsx
}
return (
<Alert bsStyle="info">
No query history yet...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a todo that this needs to be wrapper for translation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just assume all strings exposed to users need to be wrapped somehow, otherwise there'll be todos everywhere...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true enough 👍

@mistercrunch mistercrunch merged commit 38b8db8 into master Aug 30, 2016
@mistercrunch mistercrunch deleted the carapal branch August 30, 2016 04:55
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
feat(legacy-plugin-chart-event-flow): migrate package (apache#514)
16c7ce2
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
feat(legacy-plugin-chart-event-flow): migrate package (apache#514)
f09b20c
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
feat(legacy-plugin-chart-event-flow): migrate package (apache#514)
28404f8
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
feat(legacy-plugin-chart-event-flow): migrate package (apache#514)
ae6a1bb
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
airbnb Airbnb related 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mistercrunch @landscape-bot @coveralls @naveenh1 @bkyryliuk @ascott