LIMIT statement is not correctly caught by the current regular expression

[conglei]

The current logic of catching LIMIT statement has an assumption that it will be always at the very end of a sql query. Due to this, the table content preview is broken on sqlite, since LIMIT 100 OFFSET 0 will be attached (from SqlAlchemy library). It results an extra LIMIT 1000000 being added and cause the fatal error.

The current RE:

limit_pattern = re.compile(r"""
	(?ix)          # case insensitive, verbose
	\s+            # whitespace
	LIMIT\s+(\d+)  # LIMIT $ROWS
	;?             # optional semi-colon
	(\s|;)*$       # remove trailing spaces tabs or semicolons
	""")

The possible solution:

limit_pattern = re.compile(r"""
	(?ix)          # case insensitive, verbose
	\s+            # whitespace
	LIMIT\s+(\d+)  # LIMIT $ROWS
	(\s|;|.)*$     # remove the rest
	""")

However, still, it cannot correctly capture all the cases.

Any suggestion is welcome!

[john-bodley]

Note SQLAlchemy enforces an offset for SQLite whenever a limit is present as described in this issue.