Allow for multiple columns in NOT GROUP BY #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, let's that in, as mentioned before we should remove the need for this hack and handle this in |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat(plugin-chart-choropleth-map): scaffold and load map (apache#527) * feat: add package * feat: storybook working * feat: load usa and world map * refactor: clean up * fix: remove test data * refactor: utilize dynamic import * build: remove unused dependencies * fix: address pr comments * fix: comment * feat(plugin-chart-choropleth-map): add more country maps (apache#529) * feat(plugin-chart-choropleth-map): add zooming (apache#528) * feat: add zooming * feat: can zoom in and out * feat: add zoom controls * refactor: extract controls * fix: address comments * feat(plugin-chart-choropleth-map): add encoding (apache#541) * feat: add encoder * feat: add encoding * docs: add categorical * fix: any * docs: update storybook * feat(plugin-chart-choropleth-map): add tooltip (apache#548) * feat: support tooltip * feat: support tooltip fields * fix: default projection * build: bump dependency * build: update dependency * build: mark private
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat(plugin-chart-choropleth-map): scaffold and load map (apache#527) * feat: add package * feat: storybook working * feat: load usa and world map * refactor: clean up * fix: remove test data * refactor: utilize dynamic import * build: remove unused dependencies * fix: address pr comments * fix: comment * feat(plugin-chart-choropleth-map): add more country maps (apache#529) * feat(plugin-chart-choropleth-map): add zooming (apache#528) * feat: add zooming * feat: can zoom in and out * feat: add zoom controls * refactor: extract controls * fix: address comments * feat(plugin-chart-choropleth-map): add encoding (apache#541) * feat: add encoder * feat: add encoding * docs: add categorical * fix: any * docs: update storybook * feat(plugin-chart-choropleth-map): add tooltip (apache#548) * feat: support tooltip * feat: support tooltip fields * fix: default projection * build: bump dependency * build: update dependency * build: mark private
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat(plugin-chart-choropleth-map): scaffold and load map (apache#527) * feat: add package * feat: storybook working * feat: load usa and world map * refactor: clean up * fix: remove test data * refactor: utilize dynamic import * build: remove unused dependencies * fix: address pr comments * fix: comment * feat(plugin-chart-choropleth-map): add more country maps (apache#529) * feat(plugin-chart-choropleth-map): add zooming (apache#528) * feat: add zooming * feat: can zoom in and out * feat: add zoom controls * refactor: extract controls * fix: address comments * feat(plugin-chart-choropleth-map): add encoding (apache#541) * feat: add encoder * feat: add encoding * docs: add categorical * fix: any * docs: update storybook * feat(plugin-chart-choropleth-map): add tooltip (apache#548) * feat: support tooltip * feat: support tooltip fields * fix: default projection * build: bump dependency * build: update dependency * build: mark private
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat(plugin-chart-choropleth-map): scaffold and load map (apache#527) * feat: add package * feat: storybook working * feat: load usa and world map * refactor: clean up * fix: remove test data * refactor: utilize dynamic import * build: remove unused dependencies * fix: address pr comments * fix: comment * feat(plugin-chart-choropleth-map): add more country maps (apache#529) * feat(plugin-chart-choropleth-map): add zooming (apache#528) * feat: add zooming * feat: can zoom in and out * feat: add zoom controls * refactor: extract controls * fix: address comments * feat(plugin-chart-choropleth-map): add encoding (apache#541) * feat: add encoder * feat: add encoding * docs: add categorical * fix: any * docs: update storybook * feat(plugin-chart-choropleth-map): add tooltip (apache#548) * feat: support tooltip * feat: support tooltip fields * fix: default projection * build: bump dependency * build: update dependency * build: mark private
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, choosing multiple columns for NOT GROUP BY (all_columns field) in TableViz and saving/overwriting the slice will only save the first column chosen.