Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an option to make separators in dashboard #699

Merged
merged 1 commit into from
Jul 14, 2016

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jun 30, 2016

Implemented as a an option in the Markup viz to basically style the container differently. No borders, no padding, overflow:visible, ...

screen shot 2016-06-29 at 8 11 52 pm

@coveralls
Copy link

coveralls commented Jun 30, 2016

Coverage Status

Coverage remained the same at 81.085% when pulling 7fcf220812863f90a17ef4f86bfd4fe3040017cb on mistercrunch:separator into fa65888 on airbnb:master.

@georgeke
Copy link
Contributor

lgtm

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage remained the same at 81.139% when pulling 243cbf84412cba703bbbb390ef50c497803cad47 on mistercrunch:separator into b295436 on airbnb:master.

@mistercrunch mistercrunch force-pushed the separator branch 2 times, most recently from 4e8a46d to 5926729 Compare July 14, 2016 02:03
@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 81.139% when pulling 59267299a34d3eaeb15e3b2c1b82d2dc577e4129 on mistercrunch:separator into b295436 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 81.139% when pulling 59267299a34d3eaeb15e3b2c1b82d2dc577e4129 on mistercrunch:separator into b295436 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage remained the same at 81.139% when pulling b721be98b1084666682392379d5ced8a254a7f43 on mistercrunch:separator into b295436 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage increased (+0.02%) to 81.156% when pulling f8448fa9cfb362c9574449a2f160c2dd63ee58ee on mistercrunch:separator into b295436 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 14, 2016

Coverage Status

Coverage increased (+0.02%) to 81.162% when pulling 1542be4 on mistercrunch:separator into b295436 on airbnb:master.

@mistercrunch mistercrunch merged commit 8312f1c into apache:master Jul 14, 2016
@mistercrunch mistercrunch deleted the separator branch July 14, 2016 03:40
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants