deck.gl Screen Grid doesn't display colour selector

[fzzylogic]

For current master branch (2019-08-10):

"deck.gl Screen Grid" doesn't display colour selector or grid size. "Switching to deck.gl Grid" shows the colour selector and grid size and setting the colour there, affects the colour displayed when switching back to deck.gl Screen Grid.

Expected results

Colour selector and grid size controls should display on deck.gl Screen Grid, not just Grid. Not sure if colour selector is supposed to display on Grid, as it doesn't seem to work for Grid.

Actual results

As described above.

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

1. Make a new chart of type deck.gl Screen Grid.
2. See error

Environment

(please complete the following information):

• superset version: 0.999.0dev as shown in packages.json
• python version: 3.7.2
• node.js version: v12.8.0
• npm version: 6.10.3

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Loving Superset ^^

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

@Stale It's only stale if it's been fixed ^^

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

@Stale It's only stale if it's been fixed ^^

[mistercrunch]

Do you not see it under the "Customize" tab?

[fzzylogic]

@mistercrunch I got Screen Grid and Grid confused sorry for the mixup. Screen Grid works correctly. At https://demo.superset.cloud/chart/list/ open 'Grid' and expand 'Map'. It has 'Fixed Color' in there too. Adjusting it makes no difference to Grid, but if one subsequently switches 'Visualisation Type' to 'Deck.gl - Screen Grid', the color will have been set there. Thanks. (and clearly i didn't see the Customize tab on Screen Grid either ^^)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

@Stale It's only stale if it's been fixed ^^

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

@Stale It's only stale if it's been fixed ^^

[fzzylogic]

'Fixed color' still appears in two places: 1) Deck.gl Grid under the Map accordion and 2) Deck.gl Screen Grid in the Visual properties tab. Changing it under Grid has no effect on the map. Switching visualization type to Screen Grid, shows whatever color was selected under Grid and the color is shown on the map. Superset is fantastic btw.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

@mistercrunch Screenshots may help.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[fzzylogic]

https://demo.superset.cloud/chart/list/ open 'Grid' and expand 'Map' -> fixed colour still present, see screenshots above.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[junlincc]

@fzzylogic looks like you are on a very old version... i doubt it has been fixed in master but please try..unlikely we will push a fix for deck.gl chart, but if you can open a PR, we will help get it through:)

[fzzylogic]

@junlincc Thanks for the reply! This is not a big issue, just kept answering stale bot because it's still a thing. Fwiw, the screenshots are from the online demo, not sure what version it is. On the demo site, open "deck.gl Demo". Then for the "Grid", click the ellipsis to the right and "Explore chart". As in the screenshot, under the "Map" section, there is a "Fixed Color" option. Changing it has no effect. That's all, thanks ^^.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.