Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] tweaks and improvements #965

Merged
merged 6 commits into from
Aug 17, 2016
Merged

[ui] tweaks and improvements #965

merged 6 commits into from
Aug 17, 2016

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Aug 17, 2016 •
edited

  • don't make panel headings collapsable (we can bring this back if it's a well used feature, but i'd rather simplify the ui if it's not being used)
  • fix ui for long slice titles
  • make slice containers use panel + panel-default as well as panel-heading, panel-title for consistency
  • last fix for this issue: [ui] fix /caravel/theme #897

before:
screenshot 2016-08-16 19 58 31

after:
screenshot 2016-08-16 19 55 55

plz review @mistercrunch

@mistercrunch
Copy link
Member

LGTM!

@mistercrunch
Copy link
Member

Preparing an airbnb_prod realease, so I'm merging this in now

@mistercrunch mistercrunch merged commit 379cf6c into apache:master Aug 17, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kgabryje @zhaoyongjie
fix(legacy-plugin-chart-map-box): fix downloading map as image (apach…
23133fd 
…e#965)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kgabryje @zhaoyongjie
fix(legacy-plugin-chart-map-box): fix downloading map as image (apach…
4b6b7d6 
…e#965)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kgabryje @zhaoyongjie
fix(legacy-plugin-chart-map-box): fix downloading map as image (apach…
4f53ab8 
…e#965)
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kgabryje @zhaoyongjie
fix(legacy-plugin-chart-map-box): fix downloading map as image (apach…
e903988 
…e#965)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ascott @mistercrunch