TAP5-2708/2753: CssCompressor updates and CSS variable fixes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iginal tests The CssCompressor in tapestry-webresources is now based on the latest YUI commit cf0497e. To make it work some errors had to be fixed: - Duplicate variable declaration of "oldCss" - Faulty non-escaped regex - zeros.css test failed I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further, as the original YUI project is dead.
* compress now static instead of instance-bound * compress accepts String and InputStream * bootstrap.css added to Spec for better integrity * StringBuffer -> StringBuilder * Generic types added
benweidig
added a commit
that referenced
this pull request
Jun 23, 2023
The CssCompressor in tapestry-webresources is now based on the latest YUI commit cf0497e. To make the original code work it needed some error fixing: - Duplicate variable declaration of "oldCss" - Faulty non-escaped regex - zeros.css test failed I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further, as the original YUI project is dead. All the pre-existing tests from YUI are now run directly in Tapestry, and we can add our own tests easily. Furthermore, the code was cleaned up with pre-compiled Patterns, and no longer converting between Strings/Readers/Writers. Co-authored-by: Volker Lamp <vlamp@apache.org>
|
The PR was merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the CssCompressor with the latest commit yui/yuicompressor@cf0497e and moved all CSS related tests and create a Spec.
The YUI Compressor is dead, and not in a nice state...
To make it work I had to fix some compile and runtime issues:
I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further.
We had multiple issues with it before, and I looked for possible replacements, but only found quite large dependencies compared to the single Java file right now.
The next steps would be going over the issues of YUI Compressor, create test files, and adapt our code accordingly.
After that, I may want to improve it by cleaning it up and pre-compiling Regexes, etc.
Also, an easier way to disable compression for single files would be nice.