Create java-compatibility.adoc [TOMEE-2540] #486
Conversation
This is a live document until TomEE 8.0.0 is released. Till that point of time, any updates (either additions/removal) of Java versions support can be done to this document
docs/java-compatibility.adoc
Outdated
| :jbake-type: page | ||
| :jbake-status: published | ||
|
|
||
| TomEE 8.0.x is Java EE 7, Java 8 & Java 10. Any OS that supports Java 10 works |
There was a problem hiding this comment.
change Java EE 7 to Java EE 8
There was a problem hiding this comment.
Java 10 ended support in September 2018, there is no more release for it.
There was a problem hiding this comment.
Updated with correct version
Thanks
modified as per review comments thank you
For specific 8.0.0 version as of now In future we might replace minor version with x like 8.0.x
There is a version typo Made the changes to reflect Java 11
|
@cesarhernandezgt when you have time, can you please have a review on this and let me know if any changes are required, else please approve |
There was a problem hiding this comment.
My only suggestion would be to change 8.0.x and 8.0.0 with 8.0.0-M3 . Since we don't have a TomEE 8.0.0 release yet and this documentation will end up been published on the website.
Also a note like the one we have on the /download page looks good:
Note: Please note the 8.0.0-M3 release is a milestone release intended for evaluation purposes and should not be used in production.
|
btw, @dineshkumarg it's useful to have the JIRA ticket ID as part of the GitHub issue title to keep nice integration and easiness of navigation flow when we are reviewing PR :). |
dineshkumarg
changed the title
taken care @cesarhernandezgt |
@cesarhernandezgt can you post me full URL of /download page, I couldn't edit this one https://tomee.apache.org/download-ng.html |
docs/java-compatibility.adoc
Outdated
| :jbake-type: page | ||
| :jbake-status: published | ||
|
|
||
| TomEE 8.0.0-M3 is Java EE 8 & Java 11. Any OS that supports Java 11 works |
There was a problem hiding this comment.
As far as I know, TomEE 8.0.0-M3 is still not built using Java 11.
There was a problem hiding this comment.
So, TomEE 8.0.0-M3 is only Java EE 8 as of now?
There was a problem hiding this comment.
But it works fine @ runtime with Java 11even if it is not build with it :)
There was a problem hiding this comment.
Hi @rzo1 , Base on a couple of thread on the mailing list [1]. Current TomEE M3 and therefore master branch doesn't fully compile nor pass yet all the test when runs on Java 11. The impression TomEE M3 runs on Java 11 may be true for a couple of apps but the server is not yet fully Java 11 compatible. That's why I think advertising on the website that TomEE M3 is Java 11 compatible may be misleading for the reader.
[1] https://lists.apache.org/list.html?dev@tomee.apache.org:lte=6M:java%2011
There was a problem hiding this comment.
@cesarhernandezgt please check the document where I made changes, if the statements under Note are good. Or suggest a better notes which can be published
Thanks
There was a problem hiding this comment.
done, I marked as +1, thanks much :)
|
@dineshkumarg |
|
Looks great. Really fantastic to see this kind of thing get documented and nailed down. Small but important step. Thank you @dineshkumarg ! |
|
Thanks @dblevins @cesarhernandezgt @rzo1 @Daniel-Dos @gilbertoca for your help and support |
This is a live document until TomEE 8.0.0 is released. Till that point of time, any updates (either additions/removal) of Java versions support can be done to this document