Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] Update error messages to be more user-friendly #17021

Merged
merged 1 commit into from
May 25, 2024
Merged

[WebGPU] Update error messages to be more user-friendly #17021

merged 1 commit into from
May 25, 2024

Conversation

Neet-Nestor
Copy link
Contributor

This PR updates the error message returned if the client doesn't have valid WebGPU adapter to make it more readible and user-friendly.

@Neet-Nestor Neet-Nestor mentioned this pull request May 22, 2024
Merged
CharlieFRuan pushed a commit to mlc-ai/web-llm that referenced this pull request May 23, 2024
@Neet-Nestor
[WebGPU] Refine no WebGPU error message (#417)
0bab1f4 
This PR refines the error message if no WebGPU is available and unifies
the message with TVM one.

apache/tvm#17021
@tqchen
Copy link
Member

tqchen commented May 23, 2024

@tvm-bot rerun

@github-actions GitHub Actions
Copy link
Contributor

Failed to re-run CI in https://github.com/apache/tvm/actions/runs/9207373097

Traceback (most recent call last):
  File "ci/scripts/github/github_tvmbot.py", line 595, in comment_failure
    raise item
  File "ci/scripts/github/github_tvmbot.py", line 701, in run
    pr.rerun_jenkins_ci()
  File "ci/scripts/github/github_tvmbot.py", line 554, in rerun_jenkins_ci
    post(url, auth=("tvm-bot", TVM_BOT_JENKINS_TOKEN))
  File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 53, in post
    with request.urlopen(req, data) as response:
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 500: Server Error

with response


  
  <!DOCTYPE html><html><head resURL="/static/4ef693da" data-rooturl="" data-resurl="/static/4ef693da" data-extensions-available="true" data-unit-test="false" data-imagesurl="/static/4ef693da/images" data-crumb-header="Jenkins-Crumb" data-crumb-value="950b0f60bfdc38eebf2393702e094c869de6cdbea0b88a4d89718d189b3f9de2551d9898f02d78412f8001e5fd96c8d4ba28b190ed71faf16bbe5f372b2bfba9">
    
    

    <title>Jenkins [Jenkins]</title><link rel="stylesheet" href="/static/4ef693da/jsbundles/styles.css" type="text/css"><link rel="stylesheet" href="/static/4ef693da/css/responsive-grid.css" type="text/css"><link rel="shortcut icon" href="/static/4ef693da/favicon.ico" type="image/vnd.microsoft.icon"><script src="/static/4ef693da/scripts/prototype.js" type="text/javascript"></script><script src="/static/4ef693da/scripts/behavior.js" type="text/javascript"></script><script src='/adjuncts/4ef693da/org/kohsuke/stapler/bind.js' type='text/javascript'></script><script src="/static/4ef693da/scripts/yui/yahoo/yahoo-min.js"></script><script src="/static/4ef693da/scripts/yui/dom/dom-min.js"></script><script src="/static/4ef693da/scripts/yui/event/event-min.js"></script><script src="/static/4ef693da/scripts/yui/animation/animation-min.js"></script><script src="/static/4ef693da/scripts/yui/dragdrop/dragdrop-min.js"></script><script src="/static/4ef693da/scripts/yui/container/container-min.js"></script><script src="/static/4ef693da/scripts/yui/connection/connection-min.js"></script><script src="/static/4ef693da/scripts/yui/datasource/datasource-min.js"></script><script src="/static/4ef693da/scripts/yui/autocomplete/autocomplete-min.js"></script><script src="/static/4ef693da/scripts/yui/menu/menu-min.js"></script><script src="/static/4ef693da/scripts/yui/element/element-min.js"></script><script src="/static/4ef693da/scripts/yui/button/button-min.js"></script><script src="/static/4ef693da/scripts/yui/storage/storage-min.js"></script><script src="/static/4ef693da/scripts/hudson-behavior.js" type="text/javascript"></script><script src="/static/4ef693da/scripts/sortable.js" type="text/javascript"></script><link rel="stylesheet" href="/static/4ef693da/scripts/yui/container/assets/container.css" type="text/css"><link rel="stylesheet" href="/static/4ef693da/scripts/yui/container/assets/skins/sam/container.css" type="text/css"><link rel="stylesheet" href="/static/4ef693da/scripts/yui/menu/assets/skins/sam/menu.css" type="text/css"><link rel="search" href="/opensearch.xml" type="application/opensearchdescription+xml" title="Jenkins"><meta name="ROBOTS" content="INDEX,NOFOLLOW"><meta name="viewport" content="width=device-width, initial-scale=1"><script src="/static/4ef693da/jsbundles/vendors.js" type="text/javascript"></script><script src="/static/4ef693da/jsbundles/page-init.js" type="text/javascript"></script><script src="/static/4ef693da/jsbundles/sortable-drag-drop.js" type="text/javascript"></script></head><body data-model-type="hudson.model.Hudson" id="jenkins" class="yui-skin-sam one-column jenkins-2.361.2" data-version="2.361.2"><a href="#skip2content" class="skiplink">Skip to content</a><header id="page-header" class="page-header"><div class="page-header__brand"><div class="logo"><a id="jenkins-home-link" href="/"><img src="/static/4ef693da/images/svgs/logo.svg" alt="[Jenkins]" id="jenkins-head-icon"><img src="/static/4ef693da/images/title.svg" alt="Jenkins" width="139" id="jenkins-name-icon" height="34"></a></div><a href="/" class="page-header__brand-link"><img src="/static/4ef693da/images/svgs/logo.svg" alt="[Jenkins]" class="page-header__brand-image"><span class="page-header__brand-name">Jenkins</span></a></div><div class="searchbox hidden-xs"><form role="search" method="get" name="search" action="/search/" style="position:relative;" class="no-json"><div id="search-box-sizer"></div><div id="searchform"><input role="searchbox" name="q" placeholder="Search" id="search-box" class="main-search__input"><span class="main-search__icon-leading"><svg class="" class="" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" class="" viewBox="0 0 512 512"><title></title><path d="M221.09 64a157.09 157.09 0 10157.09 157.09A157.1 157.1 0 00221.09 64z" fill="none" stroke="currentColor" stroke-miterlimit="10" stroke-width="32"/><path fill="none" stroke="currentColor" stroke-linecap="round" stroke-miterlimit="10" stroke-width="32" d="M338.29 338.29L448 448"/></svg></span><a href="https://www.jenkins.io/redirect/search-box" class="main-search__icon-trailing"><svg class="" class="" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path d="M256 40a216 216 0 10216 216A216 216 0 00256 40z" fill="none" stroke="currentColor" stroke-miterlimit="10" stroke-width="38"/><path d="M200 202.29s.84-17.5 19.57-32.57C230.68 160.77 244 158.18 256 158c10.93-.14 20.69 1.67 26.53 4.45 10 4.76 29.47 16.38 29.47 41.09 0 26-17 37.81-36.37 50.8S251 281.43 251 296" fill="none" stroke="currentColor" stroke-linecap="round" stroke-miterlimit="10" stroke-width="38"/><circle cx="250" cy="360" r="25" fill="currentColor"/></svg></a><div id="search-box-completion" data-search-url="/search/"></div><script src='/adjuncts/4ef693da/jenkins/views/JenkinsHeader/search-box.js' type='text/javascript'></script></div></form></div><div class="login page-header__hyperlinks"><div id="visible-am-insertion" class="page-header__am-wrapper"></div><div id="visible-sec-am-insertion" class="page-header__am-wrapper"></div><a href="/securityRealm/commenceLogin?from=%2Fjob%2Ftvm-arm%2Fjob%2FPR-17021%2FbuildWithParameters"><b>log in</b></a></div></header><script src="/static/4ef693da/jsbundles/keyboard-shortcuts.js" type="text/javascript"></script><div id="breadcrumbBar"><script src='/adjuncts/4ef693da/lib/layout/breadcrumbs.js' type='text/javascript'></script><div class="top-sticker noedge"><div class="top-sticker-inner"><div class="jenkins-breadcrumbs"><ul id="breadcrumbs"><li class="item"><a href="/" class="model-link">Dashboard</a></li><li href="/" class="children"></li></ul><div id="breadcrumb-menu-target"></div></div></div></div></div><div id="page-body" class="clear"><div id="main-panel"><a name="skip2content"></a><h1 style="text-align: center"><img src="/static/4ef693da/images/rage.svg" width="154" height="179"><span style="font-size:50px"> Oops!</span></h1><div id="error-description"><h2 style="text-align: center">A problem occurred while processing the request.</h2><p style="text-align: center">Logging ID=142ecf9d-88b2-4952-b0f8-a67a625334cb</div></div></div><footer class="page-footer"><div class="container-fluid"><div class="page-footer__flex-row"><div class="page-footer__footer-id-placeholder" id="footer"></div><div class="page-footer__links rest_api hidden-xs"><a href="api/">REST API</a></div><div class="page-footer__links page-footer__links--white jenkins_ver"><a rel="noopener noreferrer" href="https://www.jenkins.io/" target="_blank">Jenkins 2.361.2</a></div></div></div></footer></body></html>

@tqchen
Copy link
Member

tqchen commented May 24, 2024

@tvm-bot rerun

@github-actions GitHub Actions
Copy link
Contributor

Failed to re-run CI in https://github.com/apache/tvm/actions/runs/9218797178

Traceback (most recent call last):
  File "ci/scripts/github/github_tvmbot.py", line 595, in comment_failure
    raise item
  File "ci/scripts/github/github_tvmbot.py", line 701, in run
    pr.rerun_jenkins_ci()
  File "ci/scripts/github/github_tvmbot.py", line 554, in rerun_jenkins_ci
    post(url, auth=("tvm-bot", TVM_BOT_JENKINS_TOKEN))
  File "/home/runner/work/tvm/tvm/ci/scripts/jenkins/git_utils.py", line 53, in post
    with request.urlopen(req, data) as response:
  File "/usr/lib/python3.8/urllib/request.py", line 222, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.8/urllib/request.py", line 531, in open
    response = meth(req, response)
  File "/usr/lib/python3.8/urllib/request.py", line 640, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.8/urllib/request.py", line 569, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 502, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.8/urllib/request.py", line 649, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 404: Not Found

with response

<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1"/>
<title>Error 404 Not Found</title>
</head>
<body><h2>HTTP ERROR 404 Not Found</h2>
<table>
<tr><th>URI:</th><td>/job/tvm-arm/job/PR-17021/buildWithParameters</td></tr>
<tr><th>STATUS:</th><td>404</td></tr>
<tr><th>MESSAGE:</th><td>Not Found</td></tr>
<tr><th>SERVLET:</th><td>Stapler</td></tr>
</table>
<hr/><a href="https://eclipse.org/jetty">Powered by Jetty:// 10.0.11</a><hr/>

</body>
</html>

@tqchen tqchen merged commit f498cef into apache:main May 25, 2024
14 checks passed
@CharlieFRuan CharlieFRuan mentioned this pull request May 30, 2024
Merged
CharlieFRuan added a commit to mlc-ai/web-llm that referenced this pull request May 30, 2024
@CharlieFRuan
[Version] Bump version to 0.2.39, update prebuilt WASMs (#436)
0ba1548 
### Changes
Main changes include:
- New prebuilt models:
  - Phi3-mini
  - StableLM-2-zephyr-1.6B
  - Qwen1.5-1.8B
  - Hermes2-Pro-Llama-3-8B to prebuilt models
- Updates on `ModelRecord` fields
  - For detail see: #435
- Update all WASMs
  - For detail see: #433
  - Update all WASMs to v0.2.39
- Support grammar for Llama3, hence update examples/json-mode to use
`Llama3` and `Hermes2-pro-Llama3-8B` for function calling in
`examples/json-schema`
- Use `loglevel` package:
  - For details see #427
- Fix `index.js.map` issue for Vite
  - #420
- Enhance error handling and ServiceWorker

### TVMjs
TVMjs compiled at
apache/tvm@71f7af7
- Main changes include: 
  - apache/tvm#17031
  - apache/tvm#17028
  - apache/tvm#17021

### WASM version
- All wasms updated to 0.2.39 via
mlc-ai/binary-mlc-llm-libs#123 for new MLC-LLM
runtime (mainly grammar)
@ysh329 ysh329 mentioned this pull request Jul 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Neet-Nestor @tqchen