Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUNTIME][IR] String operator+ #5792

Closed
tqchen opened this issue Jun 12, 2020 · 7 comments
Closed

[RUNTIME][IR] String operator+ #5792

tqchen opened this issue Jun 12, 2020 · 7 comments

Comments

@tqchen
Copy link
Member

tqchen commented Jun 12, 2020

We have a few places in the code base that uses operator+ of String. Right now:

Given that operator+ is quite common, and we can have a better solution in these cases(by allocating the right result length then copy), perhaps we should have a good overload for most cases.

@tqchen
Copy link
Member Author

tqchen commented Jun 12, 2020

cc @zhiics @wweic @junrushao1994

@tqchen tqchen changed the title [RUNTIME] String operator+ [RUNTIME][IR] String operator+ Jun 12, 2020
@junrushao
Copy link
Member

I agree, not sure about the performance impact though

@tqchen
Copy link
Member Author

tqchen commented Jun 12, 2020

k, it is mainly about the usability, than the perf aspect

@zhiics
Copy link
Member

zhiics commented Jun 13, 2020

Besides this, I think we should make the comparison operators free functions instead of member functions because they are not communicative.

@tqchen
Copy link
Member Author

tqchen commented Jun 14, 2020

@zhiics would you be interested in taking a stab?

@zhiics
Copy link
Member

zhiics commented Jun 15, 2020

#5806

@tqchen tqchen closed this as completed Jun 17, 2020
@tqchen
Copy link
Member Author

tqchen commented Jun 17, 2020

Closing thanks to @zhiics !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants