New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUNTIME][IR] String operator+ #5792
Comments
I agree, not sure about the performance impact though |
k, it is mainly about the usability, than the perf aspect |
Besides this, I think we should make the comparison operators free functions instead of member functions because they are not communicative. |
@zhiics would you be interested in taking a stab? |
Closing thanks to @zhiics ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a few places in the code base that uses operator+ of String. Right now:
Given that operator+ is quite common, and we can have a better solution in these cases(by allocating the right result length then copy), perhaps we should have a good overload for most cases.
The text was updated successfully, but these errors were encountered: