Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][FRONTEND] Pytorch Importer mm #8392

Closed
tqchen opened this issue Jul 2, 2021 · 6 comments · Fixed by #8397
Closed

[BUG][FRONTEND] Pytorch Importer mm #8392

tqchen opened this issue Jul 2, 2021 · 6 comments · Fixed by #8397
Assignees
@masahi @jcf94

Comments

@tqchen
Copy link
Member

tqchen commented Jul 2, 2021

Caught this when reading through the code. Dense requires transposition.

https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/pytorch.py#L1880
@tqchen
Copy link
Member Author

tqchen commented Jul 2, 2021

cc @masahi

@tqchen tqchen mentioned this issue Jul 3, 2021
Merged
@tqchen
Copy link
Member Author

tqchen commented Jul 3, 2021

tracking an related error here https://discuss.tvm.apache.org/t/pytorch-unable-to-import-a-simple-torch-nn-linear-to-relay/10383

@tqchen
Copy link
Member Author

tqchen commented Jul 3, 2021

cc @jcf94 @comaniac

@masahi
Copy link
Member

masahi commented Jul 3, 2021

Yeah torch.mm expects non-transposed input, so our converter doesn't seem correct. https://pytorch.org/docs/stable/generated/torch.mm.html

I wonder why the test cases didn't catch this...

@masahi masahi self-assigned this Jul 3, 2021
@masahi masahi mentioned this issue Jul 3, 2021
Merged
@masahi
Copy link
Member

masahi commented Jul 3, 2021

Sorry for the confusion, this converter is not used anywhere. Removed in #8397

@jcf94
Copy link
Contributor

jcf94 commented Jul 5, 2021 •
edited

Sorry for my late reply, what's the latest update to this bug?
The nn.matmul should currently only be enabled in TensorFlow frontend with extra parameters.

Ok, seems it has been fixed in #8397 ? Thanks @masahi .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masahi masahi

@jcf94 jcf94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Torch] Remove unused conversion masahi/tvm
3 participants
@masahi @tqchen @jcf94