New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whimsy failed to find Thanks link #191
Comments
The link body includes the following: (opens new window) This is not expected to be present as part of the link text. Given that it is not visible, I wonder what it is doing? |
Can |
The purpose of this check is to ensure that at least "Thanks", a common English word, appears in the link text, and it goes to the correct page. There's no policy reason to forbid the extra text, it just requires someone to update and test a new regex for the actual check code: https://github.com/apache/whimsy/blob/master/lib/whimsy/sitestandards.rb#L71 |
However that is not what the policy currently says. As to opening in a separate window, that is not an issue. |
The check result in https://whimsy.apache.org/pods/project/teaclave shows no link to
Thanks
. However, we have added theThanks
link in http://teaclave.incubator.apache.org/ at the top right of the web page. The source code is in https://github.com/henrysun007/incubator-teaclave-website.Does anyone know the reason?
The text was updated successfully, but these errors were encountered: