[ZOOKEEPER-4647] Tests don't pass on JDK20 because we try to mock InetAddress #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
force-pushed
the
ZOOKEEPER-4647-upgrade-mockito
branch
from
1f8170c
to
a43cd32
Compare
eolivelli
changed the title
cnauroth
reviewed
Jan 17, 2023
There was a problem hiding this comment.
@eolivelli , thank you for the patch. It looks good overall. I entered one question about potential impact to total test coverage.
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTrustManagerTest.java
Show resolved
Hide resolved
cnauroth
reviewed
Jan 18, 2023
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTrustManagerTest.java
Show resolved
Hide resolved
zookeeper-server/src/test/java/org/apache/zookeeper/common/ZKTrustManagerTest.java
Show resolved
Hide resolved
tisonkun
approved these changes
Feb 9, 2023
|
@cnauroth any other comments ? |
…tAddress - upgrade Mockito to 4.9.0 and use BurningWave DNS mock tools
eolivelli
force-pushed
the
ZOOKEEPER-4647-upgrade-mockito
branch
from
bf1422b
to
98fa34b
Compare
cnauroth
reviewed
Mar 23, 2023
There was a problem hiding this comment.
@eolivelli , sorry I went silent on this one. Belated +1, and thank you for incorporating the code review feedback!
|
@cnauroth no worries. You are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests do not pass on latest JDK20 (and also in JDK19) because we are trying to mock InetAddress.
More context here
https://issues.apache.org/jira/browse/ZOOKEEPER-4647
Unfortunately upgrading Mockito doesn't help and so I had to add Burning Wave DNS tools on the classpath.
https://dev.to/jjbrt/how-to-configure-hostname-resolution-to-use-a-universal-custom-hostname-resolver-in-java-14p0
The tests that mock InetAddress now pass on JDK19 and JDK20 on my laptop