Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client #633

Closed
wants to merge 2 commits into from
Closed

ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client #633

wants to merge 2 commits into from

Conversation

nkalmar
Copy link
Contributor

@nkalmar nkalmar commented Sep 19, 2018

No description provided.

@nkalmar nkalmar force-pushed the ZOOKEEPER-3032 branch 5 times, most recently from f2cef76 to a0f1a6d Compare September 19, 2018 20:18
@hanm
Copy link
Contributor

hanm commented Sep 19, 2018

Can we make sure to preserve the file commit history while moving these files around? I noticed recently after src/c was moved the entire commit history was lost. The commit history is a priceless treasure we probably want to preserve here, and I think there is ways in git to do that..

@nkalmar
Copy link
Contributor Author

nkalmar commented Sep 20, 2018

How can I do that? I tried a few things like git mv, but didn't work either.

As far as I know, this is how git works unfortunately. But it did not loose the history, it's just that git is tracking content, not files. It is a matter of git client how it displays.

git log will make it look like the history is lost, but using git log --follow displays the history fine.

Unfortunately, github web interface does not have this feature.

Do you know a workaround @hanm ?

@hanm
Copy link
Contributor

hanm commented Sep 20, 2018

I think github web interface does not support --follow at the moment, unfortunately, but there is a chrome extension that seems working https://chrome.google.com/webstore/detail/follow-for-github/agalokjhnhheienloigiaoohgmjdpned

In any case, as long as the history is preserved in git we should be fine - just a little bit inconvenient to look it up on github...

@nkalmar
Copy link
Contributor Author

nkalmar commented Sep 20, 2018

It is preserved, I double checked that. I also read multiple articles on the topic, there was a good one, which I can't find anymore...

The points was the ones I wrote - mainly, github web client can't be set to use --follow which is very unfortunate. And this is how git works. It doesn't really care about files, rather than content.

But for example, as I mentioned, in my Idea, it does the --follow automatically, at least I can see the logs just like before. So it depends on the Git client too.

There are some workarounds, but those actually rewrite the history, which is a huge NO in my opinion.

@nkalmar nkalmar force-pushed the ZOOKEEPER-3032 branch 9 times, most recently from 6336108 to ac88ca4 Compare September 21, 2018 21:16
@asfgit
Copy link

asfgit commented Sep 21, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2233/

@asfgit
Copy link

asfgit commented Sep 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2249/

@asfgit
Copy link

asfgit commented Sep 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2250/

@asfgit
Copy link

asfgit commented Sep 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2251/

@asfgit
Copy link

asfgit commented Sep 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2252/

@asfgit
Copy link

asfgit commented Sep 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2255/

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2352/

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2353/

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2354/

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2355/

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2356/

@nkalmar
Copy link
Contributor Author

nkalmar commented Oct 4, 2018

retest this please

@asfgit
Copy link

asfgit commented Oct 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2357/

@nkalmar
Copy link
Contributor Author

nkalmar commented Oct 5, 2018

retest this please

@asfgit
Copy link

asfgit commented Oct 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2358/

@nkalmar
Copy link
Contributor Author

nkalmar commented Oct 5, 2018

retest this please

@asfgit
Copy link

asfgit commented Oct 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2359/

@nkalmar
Copy link
Contributor Author

nkalmar commented Oct 5, 2018

retest this please

@asfgit
Copy link

asfgit commented Oct 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2360/

@asfgit asfgit closed this in faa7cec Oct 5, 2018
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
4b1fbb2 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
0cfdd6c 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
16b33e4 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
25ab983 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
2cc9a61 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
nkalmar added a commit to nkalmar/zookeeper that referenced this pull request Oct 5, 2018
@nkalmar
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
3a5b8b2 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
@nkalmar nkalmar mentioned this pull request Oct 5, 2018
Closed
asfgit pushed a commit that referenced this pull request Oct 8, 2018
@nkalmar @anmolnar
ZOOKEEPER-3032: MAVEN MIGRATION - branch-3.5 - move java server, client
3ce1b18 
Author: Norbert Kalmar <nkalmaryahoo.com>

Reviewers: hanmapache.org, andorapache.org

Closes #633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client

Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: andor@apache.org

Closes #656 from nkalmar/ZOOKEEPER-3032-3.5
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@nkalmar @RokLenarcic
ZOOKEEPER-3032: MAVEN MIGRATION - move java server, client
c9fad29 
Author: Norbert Kalmar <nkalmar@yahoo.com>

Reviewers: hanm@apache.org, andor@apache.org

Closes apache#633 from nkalmar/ZOOKEEPER-3032 and squashes the following commits:

3f9a0ec [Norbert Kalmar] ZOOKEEPER-3032 fix flaky QuorumPeerMainTest.testLeaderElectionWithDisloyalVoter_stillHasMajority
27295ed [Norbert Kalmar] ZOOKEEPER-3032 - MAVEN MIGRATION - move java server, client
@nkalmar nkalmar deleted the ZOOKEEPER-3032 branch October 6, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@nkalmar @hanm @asfgit @eolivelli @anmolnar