[ZOOKEEPER-4677] Cleanup code in the DataTree class #1968
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| @@ -781,7 +773,7 @@ public List<ACL> getACL(String path, Stat stat) throws KeeperException.NoNodeExc | |||
| if (stat != null) { | |||
| n.copyStat(stat); | |||
| } | |||
| return new ArrayList<ACL>(aclCache.convertLong(n.acl)); | |||
| return new ArrayList<>(aclCache.convertLong(n.acl)); | |||
There was a problem hiding this comment.
💬 5 similar findings have been found in this PR
THREAD_SAFETY_VIOLATION: Read/Write race. Non-private method DataTree.getACL(...) indirectly reads with synchronization from container this.aclCache.longKeyMap via call to Map.get(...). Potentially races with unsynchronized write in method DataTree.deserialize(...).
Reporting because this access may occur on a background thread.
🔎 Expand here to view all instances of this finding
| File Path | Line Number |
|---|---|
| zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java | 1467 |
| zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java | 195 |
| zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java | 1368 |
| zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java | 1440 |
| zookeeper-server/src/main/java/org/apache/zookeeper/server/DataTree.java | 461 |
Visit the Lift Web Console to find more details in your report.
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
@tisonkun can you please create a JIRA and change the title and the commit message ? |
tisonkun
changed the title
|
@eolivelli ticket created. Commit title should be default to PR title if you merge from WebUI. |
|
@eolivelli Manually. |
|
Merging... FYI I may take a look at sonatype-lift reports to see if we can fix or disable it, preventing merging patches with CI fails. |
Today I read the
DataTreeclass and do these cleanups along with the path.cc @symat @eolivelli