Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needed to install Prop-Types to use it #48

Closed
seastian opened this issue Aug 23, 2021 · 3 comments · Fixed by #54
Closed

Needed to install Prop-Types to use it #48

seastian opened this issue Aug 23, 2021 · 3 comments · Fixed by #54

Comments

@seastian
Copy link 

Failed to compile.

ModuleNotFoundError: Module not found: Error: Can't resolve 'prop-types' in '/node_modules/nextjs-progressbar/dist'

Maybe add prop-types as a dependency?

Thanks for this package!
@apal21
Copy link
Owner

apal21 commented Aug 25, 2021

Thanks for pointing this out. Will add this in the next release

@imranbarbhuiya imranbarbhuiya mentioned this issue Oct 29, 2021
Merged
@imranbarbhuiya
Copy link
Collaborator

This issue is now fixed in #54

@apal21
Copy link
Owner

apal21 commented Oct 29, 2021

Ohh okay. Thanks for pointing this out @imranbarbhuiya

@apal21 apal21 closed this as completed Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update to next v12
3 participants
@apal21 @seastian @imranbarbhuiya