Some false positives

[benlangfeld]

Details of some false positives here: http://gist.github.com/592051

I can't for the life of me figure out what the issue is here, but I think it comes from somewhere around line 300 of capp_lint.py

[aparajita]

Thanks, I'll look into it.

[klaaspieter]

Some more false positives:

Specifying a category (happens when copy pasting Cocoa)
acceptDrop:(id)theDragInfo

Incorrect indentation (I'd like to have some freedom here)

var highlightedBezelColor = [CPColor colorWithPatternImage:[[CPThreePartImage alloc] initWithImageSlices:[
    [[CPImage alloc] initWithContentsOfFile:highlightedLeftImage size:CGSizeMake(3.0, 30.0)],
    [[CPImage alloc] initWithContentsOfFile:highlightedFillImage size:CGSizeMake(1.0, 30.0)],
    [[CPImage alloc] initWithContentsOfFile:highlightedRightImage size:CGSizeMake(12.0, 30.0)]
] isVertical:NO]];

Declaring a property

 @outlet CPTableView _listsTableView @accessors(property=listsTableView);

[aparajita]

acceptDrop:(id)theDragInfo

What is the error you are getting?

Incorrect indentation (I'd like to have some freedom here)

You'll have to discuss it on the list to get some concensus, Alexander agreed with me that everything should be indented at least to the first character of the identifier.

Declaring a property

Will be fixed in the next commit, coming soon.

[klaaspieter]

acceptDrop:(id)theDragInfo

What is the error you are getting?

comparison operator without surrounding spaces.

[aparajita]

Then the method declaration must be malformed (perhaps missing the "-" or return type), because that check is skipped for well-formed method declarations.

[klaaspieter]

The method declaration is divider over multiple lines. My guess is that it properly skips the first line of the method declaration but doesn't for any subsequent lines.

[klaaspieter]

CPSplitView lines 628 to 634.

 if (index + 1 == count)
    viewFrame.size[_sizeComponent] = bounds.size[_sizeComponent] - viewFrame.origin[_originComponent];
else if (totalSizableSpace && isSizable && lastSizableIndex === index)
    viewFrame.size[_sizeComponent] = MAX(0, ROUND([view frame].size[_sizeComponent] + remainingFlexibleSpace))
else if (isSizable || !totalSizableSpace)
{
    viewFrame.size[_sizeComponent] = MAX(0, ROUND(ratio * [view frame].size[_sizeComponent]));
    remainingFlexibleSpace -= (viewFrame.size[_sizeComponent] - [view frame].size[_sizeComponent]);
}
else if (totalSizableSpace && !isSizable)
    viewFrame.size[_sizeComponent] = [view frame].size[_sizeComponent];

[aparajita]

Fixed. In actual fact it isn't a false positive, it's just wrongly labeled. The code after the var block is not outdented as it should be. This is specifically flagged in the latest version on master.