Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET Notifications limit #85

Open
iamraf opened this issue Sep 30, 2019 · 3 comments
Open

GET Notifications limit #85

iamraf opened this issue Sep 30, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@iamraf
Copy link

iamraf commented Sep 30, 2019

I currently have more than 700 notifications.

I would suggest that we should have a limit of 50 as well as descending sort option to get the latest ones. Or maybe remove old ones and keep some period of 3 months.
@apavlidi apavlidi added the enhancement New feature or request label Sep 30, 2019
@apavlidi
Copy link
Owner

apavlidi commented Oct 1, 2019

@h01d Nice catch. You are right we should limit the notificatioins retrieved

@asidirop
Copy link
Contributor

asidirop commented Oct 1, 2019

The api should support pagination and the number of elements should be an argument.

@iamraf
Copy link
Author

iamraf commented Oct 1, 2019 •
edited
Loading

@asidirop announcements do support pagination, I don't think notifications should have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asidirop @apavlidi @iamraf