Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activated autocomplete-bibtex package does not save session #98

Open
mbroedl opened this issue Feb 21, 2018 · 5 comments
Open

activated autocomplete-bibtex package does not save session #98

mbroedl opened this issue Feb 21, 2018 · 5 comments

Comments

@mbroedl
Copy link

mbroedl commented Feb 21, 2018

Sorry that it's me again.

Just noticed the other day, that my sessions were not saved anymore, but atom always went back to a session from a few days ago.
Activated and deactivated some of the most recently updated packages, and it turned out that autocomplete-bibtex is the evil guy. :(

So: when the package is activated, a changed session is not saved (or recalled?) by atom. Deactivating the package before closing atom does not help either.

I've no idea what might cause it.

Atom 1.23.3
autocomplete-bibtex 1.2.0

@mangecoeur
Copy link
Collaborator

Bleh, that's wierd. What do you mean by session exactly? Personally I have no issues getting back my last opened files on windows and mac...

Maybe you could try this for me: open the developer console and then close atom. Tell me if you see a flash of red error messages on the console output just before the windows closes. This might be indicative of autocomplete causing an error when it saves its current state.

@mbroedl
Copy link
Author

mbroedl commented Feb 28, 2018

With session I mean that it stores all open documents and the current status of the documents regardless of whether they were saved. So when you close atom, and then open atom again, you have the same files with the same saved or unsaved file-state open.
With autocomplete-bibtex, it stops recording these changes once I activate the package.

I get this error message when activating autocomplete-bibtex (and every time I make a change to any of the documents, or on opening/closing them).
image
I then had to take a screencast to actually get to the error message you hypothesised, but maybe it's not related to autocomplete-bibtex, but only the former one?
image

@mangecoeur
Copy link
Collaborator

mangecoeur commented Feb 28, 2018

Ok I think i know what this is and how to fix it - I thought I had disabled saving the state of autocomplete bibtex (which I did because I didn't finish work to make it work properly with the auto-updating of the reference files), but it looks like I only disabled loading the state, not saving it. As a temporary fix, try commenting out:

  • lines 39-49 in provider.js
  • lines 87-94 in main.js

. I will try a proper fix when I have time.

@mangecoeur
Copy link
Collaborator

Actually, i quickly commented out those lines myself in the dev master version, let me know it that fixes your problem

@mbroedl
Copy link
Author

mbroedl commented Feb 28, 2018

Yes, this works perfectly! No more error messages, thanks a lot. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants