Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collected fixes for LibPack 12.5.3 #19

Closed
donovaly opened this issue Nov 28, 2021 · 4 comments
Closed

collected fixes for LibPack 12.5.3 #19

donovaly opened this issue Nov 28, 2021 · 4 comments

Comments

@donovaly
Copy link

donovaly commented Nov 28, 2021

Here is a zip file: https://github.com/donovaly/FreeCADInstProj/releases/download/LibPack-fixes-1/Changes-for-LibPack-12-5-3.zip

which can be used the following way:

Changelog:


I also created a ZIP file that includes the changes to the LibPack: https://github.com/donovaly/FreeCADInstProj/releases/download/LibPack-fixes-1/FreeCADLibs_12.5.3_x64_VC17_fixes_US.7z

This was referenced Nov 28, 2021
@chennes
Copy link

chennes commented Nov 30, 2021

Using your combined fixes to compile in debug mode I am getting the following error:

CMake Error at E:/FreeCAD/FreeCADLibs_12.5.3_x64_VC17_fixes_US/FreeCADLibs_12.5.3_x64_VC17/lib/cmake/Qt5Gui/Qt5GuiConfig.cmake:14 (message):
  The imported target "Qt5::Gui" references the file

     "E:/FreeCAD/FreeCADLibs_12.5.3_x64_VC17_fixes_US/FreeCADLibs_12.5.3_x64_VC17/plugins/imageformats/qgifd.dll"

  but this file does not exist.

Call Stack (most recent call first):
  lib/cmake/Qt5Gui/Qt5GuiConfig.cmake:228 (_qt5_Gui_check_file_exists)
  lib/cmake/Qt5Gui/Qt5Gui_QGifPlugin.cmake:6 (_populate_Gui_plugin_properties)
  lib/cmake/Qt5Gui/Qt5GuiConfig.cmake:237 (include)
  lib/cmake/Qt5Widgets/Qt5WidgetsConfig.cmake:105 (find_package)
  cMake/FreeCAD_Helpers/SetupQt.cmake:15 (find_package)
  CMakeLists.txt:69 (include)

It appears that none of the debug versions of these image format libraries are present in the zip.

@donovaly
Copy link
Author

donovaly commented Dec 1, 2021

Yes, my fixes ZIP only contained files necessary for releases since my focus was to finish the release of FC 0.19.3.
But since today there is a new LibPack available so my ZIP is no longer necessary.

@donovaly
Copy link
Author

donovaly commented Dec 1, 2021

This issue can be closed once #22 is fixed.

@donovaly
Copy link
Author

#22 still stand but this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants